Bug 120795 - ScrollView::children() should return a reference.
Summary: ScrollView::children() should return a reference.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-05 14:18 PDT by Andreas Kling
Modified: 2013-09-05 17:34 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.02 KB, patch)
2013-09-05 14:26 PDT, Andreas Kling 		andersca: review+
Details | Formatted Diff | Diff
Patch for landing (9.93 KB, patch)
2013-09-05 14:38 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-05 14:18:15 PDT 
ScrollView::children() should return a reference.
Comment 1 Andreas Kling 2013-09-05 14:26:51 PDT 
Created attachment 210662 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-05 14:28:49 PDT 
Attachment 210662 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp', u'Source/WebCore/platform/ScrollView.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebView.mm']" exit_code: 1
Source/WebCore/platform/ScrollView.h:71:  Missing spaces around >>  [whitespace/operators] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-09-05 14:38:27 PDT 
Created attachment 210665 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2013-09-05 14:41:47 PDT 
Attachment 210665 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp', u'Source/WebCore/platform/ScrollView.h', u'Source/WebCore/plugins/IFrameShimSupport.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebView.mm']" exit_code: 1
Source/WebCore/platform/ScrollView.h:71:  Missing spaces around >>  [whitespace/operators] [3]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2013-09-05 17:34:01 PDT 
Comment on attachment 210665 [details]
Patch for landing

Clearing flags on attachment: 210665

Committed r155164: <http://trac.webkit.org/changeset/155164>
Comment 6 WebKit Commit Bot 2013-09-05 17:34:03 PDT 
All reviewed patches have been landed.  Closing bug.