Bug 120791 - DRY out srcset related deviceScaleFactor calculations
Summary: DRY out srcset related deviceScaleFactor calculations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-05 13:30 PDT by Yoav Weiss
Modified: 2013-09-05 22:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.45 KB, patch)
2013-09-05 13:38 PDT, Yoav Weiss 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoav Weiss 2013-09-05 13:30:28 PDT 
DRY out srcset related deviceScaleFactor calculations
Comment 1 Yoav Weiss 2013-09-05 13:38:41 PDT 
Created attachment 210656 [details]
Patch
Comment 2 Yoav Weiss 2013-09-05 14:18:46 PDT 
Identical deviceScaleFactor calculations were performed in 3 different locations.
I've added that calculation as a method of Document and replaced previous calculations by calls to this method.
Comment 3 Andreas Kling 2013-09-05 22:21:05 PDT 
Comment on attachment 210656 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2013-09-05 22:47:41 PDT 
Comment on attachment 210656 [details]
Patch

Clearing flags on attachment: 210656

Committed r155176: <http://trac.webkit.org/changeset/155176>
Comment 5 WebKit Commit Bot 2013-09-05 22:47:45 PDT 
All reviewed patches have been landed.  Closing bug.