Bug 120790 - Clean up wtf/Compiler.h
Summary: Clean up wtf/Compiler.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-05 13:17 PDT by Anders Carlsson
Modified: 2013-09-05 14:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.26 KB, patch)
2013-09-05 13:22 PDT, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-09-05 13:17:24 PDT 
Clean up wtf/Compiler.h
Comment 1 Anders Carlsson 2013-09-05 13:22:26 PDT 
Created attachment 210653 [details]
Patch
Comment 2 Andreas Kling 2013-09-05 13:27:54 PDT 
Comment on attachment 210653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210653&action=review

> Source/WTF/ChangeLog:12
> +        - Replace WTF_COMPILER_SUPPORTS_CXX_FINAL_CONTROL with a compiler quirk for versions of clang
> +          that have a buggy final implementation and fix a bug in the macro where final would be disabled
> +          for versions of clang where __clang_minor__ is less than 2, regardless of the major version.

Whoops!

> Source/WTF/wtf/Compiler.h:57
> +// Disable final on versions of Apple clang earlier than 4.2 to avoid bugs like http://webkit.org/b/119165 */

/* I think this file might need to be C compatible. */
Comment 3 Anders Carlsson 2013-09-05 14:00:34 PDT 
Committed r155146: <http://trac.webkit.org/changeset/155146>