Bug 120767 - Remove String(RefPtr<StringImpl>) constructor
Summary: Remove String(RefPtr<StringImpl>) constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-05 05:24 PDT by Mikhail Pozdnyakov
Modified: 2013-09-05 07:30 PDT (History)
5 users (show)

See Also:

Attachments
patch (1.97 KB, patch)
2013-09-05 05:28 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2013-09-05 05:24:24 PDT 
The String(RefPtr<StringImpl>) constructor should be removed for the following reasons:
1) It almost does not have clients, so it is unneeded.
2) RefPtr should never be passed by value
Comment 1 Mikhail Pozdnyakov 2013-09-05 05:28:15 PDT 
Created attachment 210604 [details]
patch
Comment 2 Anders Carlsson 2013-09-05 07:03:59 PDT 
Comment on attachment 210604 [details]
patch

Nice!

Of course, when we start dabbling with move semantics we'll probably end up changing the constructor that takes a PassRefPtr back into a RefPtr constructor ;)
Comment 3 WebKit Commit Bot 2013-09-05 07:30:31 PDT 
Comment on attachment 210604 [details]
patch

Clearing flags on attachment: 210604

Committed r155115: <http://trac.webkit.org/changeset/155115>
Comment 4 WebKit Commit Bot 2013-09-05 07:30:33 PDT 
All reviewed patches have been landed.  Closing bug.