From https://bugs.webkit.org/show_bug.cgi?id=120459. The new tags to download media to disk should be merged into the 2.2 release so the docs need updating. Also, a new unit test for the audio tag should be added.
Created attachment 210627 [details] Patch
Comment on attachment 210627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210627&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.h:75 > + * @WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_VIDEO_TO_DISK: Download video to disk. Since 2.2 Unfortunately this doesn't result in the enum appearing under the Since 2.2 section of the docs... Perhaps there is a different way, or it doesn't matter? > Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp:324 > + iter = checkCurrentItemIsStockActionAndGetNext(iter, WEBKIT_CONTEXT_MENU_ACTION_ENTER_VIDEO_FULLSCREEN, Visible); This surprised me, but without it the test will not pass!
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 210627 [details] Patch Clearing flags on attachment: 210627 Committed r155345: <http://trac.webkit.org/changeset/155345>
All reviewed patches have been landed. Closing bug.