Bug 120762 - [WK2] [GTK] Remove the test to disable AC under Wayland from WebKitWebViewGroup
Summary: [WK2] [GTK] Remove the test to disable AC under Wayland from WebKitWebViewGroup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alberto Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-05 02:05 PDT by Alberto Garcia
Modified: 2013-09-05 10:09 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.10 KB, patch)
2013-09-05 02:12 PDT, Alberto Garcia
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-09-05 02:05:15 PDT
We recently added code to disable accelerated compositing under Wayland (bug 120347).

However that code is located in WebKitWebViewGroup, which is not used by WebKitTestRunner.

One option would be to move it to webkitWebViewBaseUpdatePreferences().

But I think it would be better to just disable AC in all cases unless we actually support it, something like:

#if USE(TEXTURE_MAPPER_GL)
if (priv->redirectedWindow)
   return;
#endif

setAcceleratedCompositingEnabled(false);
Comment 1 Alberto Garcia 2013-09-05 02:12:02 PDT
Created attachment 210590 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-05 02:14:50 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Gustavo Noronha (kov) 2013-09-05 08:27:14 PDT
Comment on attachment 210590 [details]
Patch

Makes sense to me. It's a bit weird conceptually that we set a pagegroup-wide policy in each view, but it seems to be the most practical way of handling this issue, and we were already doing that anyway.
Comment 4 Alberto Garcia 2013-09-05 10:09:21 PDT
Committed r155125: <http://trac.webkit.org/changeset/155125>