Bug 120757 - [CSSRegions] RenderRegion::generatingElement should return a reference
Summary: [CSSRegions] RenderRegion::generatingElement should return a reference
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihai Maerean
URL:
Keywords:
Depends on:
Blocks: 57312
  Show dependency tree / graph
 
Reported: 2013-09-04 23:58 PDT by Mihnea Ovidenie
Modified: 2013-09-11 09:47 PDT (History)
9 users (show)

See Also:

Attachments
patch (6.75 KB, patch)
2013-09-09 04:52 PDT, Mihai Maerean 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihnea Ovidenie 2013-09-04 23:58:16 PDT 
As a follow up from https://bugs.webkit.org/show_bug.cgi?id=120397, make RenderRegion::generatingElement() return a reference instead of pointer since for regions, generatingNode cannot return 0.
Comment 1 Mihai Maerean 2013-09-09 02:04:04 PDT 
RenderRegionSet derives from RenderRegion.
Is generatingElement() always not NULL for RenderRegionSet as well? I'm thinking not.
Comment 2 Mihai Maerean 2013-09-09 04:52:13 PDT 
Created attachment 211030 [details]
patch
Comment 3 Mihnea Ovidenie 2013-09-11 09:46:03 PDT 
(In reply to comment #1)
> RenderRegionSet derives from RenderRegion.
> Is generatingElement() always not NULL for RenderRegionSet as well? I'm thinking not.

At this moment, RenderMultiColumnSet -> RenderRegionSet -> RenderRegion and RenderMultiColumnSet is created as an anonymous block. Therefore, for this type of region, generatingElement() can return NULL.

Closing this bug as invalid.