Animations in an AnimationList are never null
Created attachment 210540 [details] Patch
Comment on attachment 210540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210540&action=review I feel like I'm reviewing a patch by myself from the future. > Source/WebCore/platform/animation/AnimationList.h:52 > + void append(PassRefPtr<Animation> anim) "anim"? :P
Comment on attachment 210540 [details] Patch Attachment 210540 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1685792
Comment on attachment 210540 [details] Patch Attachment 210540 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1692764
Comment on attachment 210540 [details] Patch Attachment 210540 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1686845
Comment on attachment 210540 [details] Patch Attachment 210540 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1697473
Comment on attachment 210540 [details] Patch Attachment 210540 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1692775
Created attachment 210613 [details] Patch
Comment on attachment 210613 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210613&action=review > Source/WebCore/platform/animation/AnimationList.h:64 > + Vector<RefPtr<Animation>> m_animations; This should really be a Vector<Ref<Animation>>
Regressions: Unexpected image-only failures (1) animations/cross-fade-background-image.html [ ImageOnlyFailure ] This fails for me even without the patch.
Committed r155119: <http://trac.webkit.org/changeset/155119>