Bug 120720 - Animations in an AnimationList are never null
Summary: Animations in an AnimationList are never null
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-04 19:35 PDT by Anders Carlsson
Modified: 2013-09-05 08:15 PDT (History)
15 users (show)

See Also:

Attachments
Patch (24.24 KB, patch)
2013-09-04 19:45 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (25.13 KB, patch)
2013-09-05 07:11 PDT, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-09-04 19:35:33 PDT 
Animations in an AnimationList are never null
Comment 1 Anders Carlsson 2013-09-04 19:45:39 PDT 
Created attachment 210540 [details]
Patch
Comment 2 Andreas Kling 2013-09-04 19:48:11 PDT 
Comment on attachment 210540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210540&action=review

I feel like I'm reviewing a patch by myself from the future.

> Source/WebCore/platform/animation/AnimationList.h:52
> +    void append(PassRefPtr<Animation> anim)

"anim"? :P
Comment 3 Early Warning System Bot 2013-09-04 19:54:28 PDT 
Comment on attachment 210540 [details]
Patch

Attachment 210540 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1685792
Comment 4 Early Warning System Bot 2013-09-04 19:56:04 PDT 
Comment on attachment 210540 [details]
Patch

Attachment 210540 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1692764
Comment 5 EFL EWS Bot 2013-09-04 20:57:08 PDT 
Comment on attachment 210540 [details]
Patch

Attachment 210540 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1686845
Comment 6 kov's GTK+ EWS bot 2013-09-04 21:00:41 PDT 
Comment on attachment 210540 [details]
Patch

Attachment 210540 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1697473
Comment 7 EFL EWS Bot 2013-09-04 21:22:21 PDT 
Comment on attachment 210540 [details]
Patch

Attachment 210540 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1692775
Comment 8 Anders Carlsson 2013-09-05 07:11:40 PDT 
Created attachment 210613 [details]
Patch
Comment 9 Andreas Kling 2013-09-05 08:09:05 PDT 
Comment on attachment 210613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210613&action=review

> Source/WebCore/platform/animation/AnimationList.h:64
> +    Vector<RefPtr<Animation>> m_animations;

This should really be a Vector<Ref<Animation>>
Comment 10 Anders Carlsson 2013-09-05 08:10:39 PDT 
Regressions: Unexpected image-only failures (1)
  animations/cross-fade-background-image.html [ ImageOnlyFailure ]

This fails for me even without the patch.
Comment 11 Anders Carlsson 2013-09-05 08:15:07 PDT 
Committed r155119: <http://trac.webkit.org/changeset/155119>