Bug 120712 - Link to libdispatch_debug.lib when using DebugSuffix configuration.
Summary: Link to libdispatch_debug.lib when using DebugSuffix configuration.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-09-04 17:34 PDT by Roger Fong
Modified: 2013-09-05 11:06 PDT (History)
6 users (show)

See Also:


Attachments
patch (1.35 KB, patch)
2013-09-04 17:36 PDT, Roger Fong
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-09-04 17:34:20 PDT
It currently uses the release lib (and thus dll) when compiling in DebugSuffix mode.

<rdar://problem/14883216>
Comment 1 Roger Fong 2013-09-04 17:36:00 PDT
Created attachment 210529 [details]
patch
Comment 2 Brent Fulgham 2013-09-05 10:08:24 PDT
Comment on attachment 210529 [details]
patch

r=me
Comment 3 Roger Fong 2013-09-05 10:21:26 PDT
Committed: http://trac.webkit.org/changeset/155127
Comment 4 Brent Fulgham 2013-09-05 10:29:58 PDT
I think there are a couple of more places that have to be updated to have the full WebKit stack link properly. I'm working on this now for a different reason, and will post another patch related to this one. I think we still link against AVFoundationCF.dll, rather than AVFoundationCF_debug.dll, for example.
Comment 5 Brent Fulgham 2013-09-05 11:06:48 PDT
When using this change, we should also include http://trac.webkit.org/changeset/155130, as this corrects the AVFoundationCF linkage.