WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 120706
Rename StackIterator to StackVisitor.
https://bugs.webkit.org/show_bug.cgi?id=120706
Summary
Rename StackIterator to StackVisitor.
Mark Lam
Reported
2013-09-04 16:52:06 PDT
Renaming StackIterator to StackVisitor. Also doing some minor refactoring: - Renamed StackIterator::iterate() to StackVisitor::visit(). - Make StackVisitor::visit() a static method. - Move the instantiation of the StackVisitor instance into StackVisitor::visit() from CallFrame::iterate(). - Removed StackIterator::resetIterator() and inline its body into the StackVisitor constructor since this is the only remaining caller of it.
Attachments
the patch.
(84.77 KB, patch)
2013-09-04 16:54 PDT
,
Mark Lam
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2013-09-04 16:54:14 PDT
Created
attachment 210506
[details]
the patch.
Geoffrey Garen
Comment 2
2013-09-04 17:23:57 PDT
Comment on
attachment 210506
[details]
the patch. r=me
Mark Lam
Comment 3
2013-09-04 17:39:34 PDT
Thanks for the review. Landed in
r155081
: <
http://trac.webkit.org/r155081
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug