Bug 120706 - Rename StackIterator to StackVisitor.
Summary: Rename StackIterator to StackVisitor.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Depends on:
Reported: 2013-09-04 16:52 PDT by Mark Lam
Modified: 2013-09-04 17:39 PDT (History)
5 users (show)

See Also:

the patch. (84.77 KB, patch)
2013-09-04 16:54 PDT, Mark Lam
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2013-09-04 16:52:06 PDT
Renaming StackIterator to StackVisitor.  Also doing some minor refactoring:

- Renamed StackIterator::iterate() to StackVisitor::visit().
- Make StackVisitor::visit() a static method.
- Move the instantiation of the StackVisitor instance into StackVisitor::visit() from CallFrame::iterate().
- Removed StackIterator::resetIterator() and inline its body into the StackVisitor constructor since this is the only remaining caller of it.
Comment 1 Mark Lam 2013-09-04 16:54:14 PDT
Created attachment 210506 [details]
the patch.
Comment 2 Geoffrey Garen 2013-09-04 17:23:57 PDT
Comment on attachment 210506 [details]
the patch.

Comment 3 Mark Lam 2013-09-04 17:39:34 PDT
Thanks for the review.  Landed in r155081: <http://trac.webkit.org/r155081>.