Bug 120702 - Make ImageQualityController per-RenderView.
Summary: Make ImageQualityController per-RenderView.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2013-09-04 14:55 PDT by Andreas Kling
Modified: 2013-09-04 15:47 PDT (History)
6 users (show)

See Also:

Patch (32.68 KB, patch)
2013-09-04 15:04 PDT, Andreas Kling
andersca: review+
Details | Formatted Diff | Diff
Patch for landing (32.69 KB, patch)
2013-09-04 15:17 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-04 14:55:48 PDT
Make ImageQualityController per-RenderView.
Comment 1 Andreas Kling 2013-09-04 15:04:39 PDT
Created attachment 210499 [details]
Comment 2 WebKit Commit Bot 2013-09-04 15:08:00 PDT
Attachment 210499 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/ImageQualityController.cpp', u'Source/WebCore/rendering/ImageQualityController.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h']" exit_code: 1
Source/WebCore/rendering/ImageQualityController.h:71:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Source/WebCore/rendering/ImageQualityController.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/rendering/ImageQualityController.cpp:194:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Total errors found: 3 in 11 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-09-04 15:17:27 PDT
Created attachment 210501 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2013-09-04 15:46:58 PDT
Comment on attachment 210501 [details]
Patch for landing

Clearing flags on attachment: 210501

Committed r155077: <http://trac.webkit.org/changeset/155077>
Comment 5 WebKit Commit Bot 2013-09-04 15:47:01 PDT
All reviewed patches have been landed.  Closing bug.