Bug 120686 - Move logical dimension getters/setters to FloatingObject from RenderBlock
Summary: Move logical dimension getters/setters to FloatingObject from RenderBlock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-04 09:42 PDT by Bem Jones-Bey
Modified: 2013-09-04 11:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (32.55 KB, patch)
2013-09-04 09:50 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-09-04 09:42:36 PDT 
Move logical dimension getters/setters to FloatingObject from RenderBlock
Comment 1 Bem Jones-Bey 2013-09-04 09:50:32 PDT 
Created attachment 210472 [details]
Patch
Comment 2 Dave Hyatt 2013-09-04 10:47:17 PDT 
Comment on attachment 210472 [details]
Patch

I would like to see you make the horizontal writing mode of the block that owns the floating object be a bit on the FloatingObject. Then you have that information available, and you don't need the boolean arguments to everything.
Comment 3 Dave Hyatt 2013-09-04 10:50:50 PDT 
This doesn't have to hold up the patch though, but I think it would be a good follow-up.
Comment 4 Dave Hyatt 2013-09-04 10:51:04 PDT 
Comment on attachment 210472 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2013-09-04 11:00:27 PDT 
Comment on attachment 210472 [details]
Patch

Clearing flags on attachment: 210472

Committed r155050: <http://trac.webkit.org/changeset/155050>
Comment 6 WebKit Commit Bot 2013-09-04 11:00:30 PDT 
All reviewed patches have been landed.  Closing bug.