Bug 120669 – REGRESSION(r154781): accessibility/notification-listeners.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Zan Dobersek]

The accessibility/notification-listeners.html layout test is failing since r154781.
http://trac.webkit.org/changeset/154781

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fnotification-listeners.html

Diff:
--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/accessibility/notification-listeners-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/accessibility/notification-listeners-actual.txt
@@ -5,7 +5,29 @@
 
 
 Slider
-FAIL selectNotificationCount should be 1. Was 0.
+SELECT AXFocusedUIElementChanged
+SELECT AXFocusedUIElementChanged
+SELECT AXFocusedUIElementChanged
+SELECT AXFocusedUIElementChanged
+SELECT AXFocusedUIElementChanged
+SELECT AXFocusedUIElementChanged
+SELECT AXFocusedUIElementChanged
+SELECT AXFocusedUIElementChanged
+SELECT AXFocusedUIElementChanged
+SELECT AXFocusedUIElementChanged
+SELECT AXInvalidStatusChanged
+SELECT AXInvalidStatusChanged
+SELECT AXInvalidStatusChanged
+SELECT AXInvalidStatusChanged
+SELECT AXInvalidStatusChanged
+SELECT AXInvalidStatusChanged
+SELECT AXInvalidStatusChanged
+SELECT AXInvalidStatusChanged
+SELECT AXInvalidStatusChanged
+SELECT AXInvalidStatusChanged
+SELECT AXInvalidStatusChanged
+SELECT AXInvalidStatusChanged
+FAIL selectNotificationCount should be 1. Was 22.
 FAIL sliderNotificationCount should be 1. Was 0.
 FAIL globalNotificationCount should be 2. Was 0.
 PASS successfullyParsed is true

[Denis Nomiyama (dnomi)]

Created attachment 211332 [details]
Patch

[chris fleizach]

Comment on attachment 211332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211332&action=review

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:192
> +        return FALSE;

should this just be false (not FALSE)

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:220
> +    return TRUE;

ditto about TRUE/true

[Denis Nomiyama (dnomi)]

(In reply to comment #2)
> (From update of attachment 211332 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211332&action=review
> 
> > Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:192
> > +        return FALSE;
> 
> should this just be false (not FALSE)

Sure, I'll fix it. I based on the code at axObjectEventListener(), which has the same typo. I will fix both functions.

> > Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:220
> > +    return TRUE;
> 
> ditto about TRUE/true

Ok.

[Denis Nomiyama (dnomi)]

Created attachment 211335 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 211335 [details]
Patch

Clearing flags on attachment: 211335

Committed r155599: <http://trac.webkit.org/changeset/155599>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.