Bug 120658 – Fix uninitialized build warning in make_names.pl

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

There is build warning from r154965.

Use of uninitialized value in numeric ne (!=) at /home/gyuyoung/webkit/WebKit/Source/WebCore/dom/make_names.pl line 625.

[Gyuyoung Kim]

Created attachment 210420 [details]
Patch

[Darin Adler]

Comment on attachment 210420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210420&action=review

> Source/WebCore/dom/make_names.pl:625
> +        if (!($parsedTags{$name}{generateTypeChecks})) {

Is there a need for those parentheses?

[Gyuyoung Kim]

Created attachment 210422 [details]
Patch for landing

[Gyuyoung Kim]

(In reply to comment #2)
> (From update of attachment 210420 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=210420&action=review
> 
> > Source/WebCore/dom/make_names.pl:625
> > +        if (!($parsedTags{$name}{generateTypeChecks})) {
> 
> Is there a need for those parentheses?

I don't think there is a need in this case. Fixed.

[WebKit Commit Bot]

Comment on attachment 210422 [details]
Patch for landing

Clearing flags on attachment: 210422

Committed r155016: <http://trac.webkit.org/changeset/155016>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.