Bug 120658 - Fix uninitialized build warning in make_names.pl
Summary: Fix uninitialized build warning in make_names.pl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-03 18:39 PDT by Gyuyoung Kim
Modified: 2013-09-03 20:33 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.21 KB, patch)
2013-09-03 18:42 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch for landing (1.21 KB, patch)
2013-09-03 19:36 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-09-03 18:39:30 PDT
There is build warning from r154965.

Use of uninitialized value in numeric ne (!=) at /home/gyuyoung/webkit/WebKit/Source/WebCore/dom/make_names.pl line 625.
Comment 1 Gyuyoung Kim 2013-09-03 18:42:35 PDT
Created attachment 210420 [details]
Patch
Comment 2 Darin Adler 2013-09-03 19:12:56 PDT
Comment on attachment 210420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210420&action=review

> Source/WebCore/dom/make_names.pl:625
> +        if (!($parsedTags{$name}{generateTypeChecks})) {

Is there a need for those parentheses?
Comment 3 Gyuyoung Kim 2013-09-03 19:36:00 PDT
Created attachment 210422 [details]
Patch for landing
Comment 4 Gyuyoung Kim 2013-09-03 19:37:38 PDT
(In reply to comment #2)
> (From update of attachment 210420 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=210420&action=review
> 
> > Source/WebCore/dom/make_names.pl:625
> > +        if (!($parsedTags{$name}{generateTypeChecks})) {
> 
> Is there a need for those parentheses?

I don't think there is a need in this case. Fixed.
Comment 5 WebKit Commit Bot 2013-09-03 20:33:09 PDT
Comment on attachment 210422 [details]
Patch for landing

Clearing flags on attachment: 210422

Committed r155016: <http://trac.webkit.org/changeset/155016>
Comment 6 WebKit Commit Bot 2013-09-03 20:33:13 PDT
All reviewed patches have been landed.  Closing bug.