Bug 120646 - [EFL][WK2] Move ShouldGoToBackForwardListItem to the list of passing API tests
Summary: [EFL][WK2] Move ShouldGoToBackForwardListItem to the list of passing API tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Correia (qrwteyrutiyoup)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-03 12:09 PDT by Sergio Correia (qrwteyrutiyoup)
Modified: 2013-09-04 18:21 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2013-09-03 12:10 PDT, Sergio Correia (qrwteyrutiyoup) 		no flags Details | Formatted Diff | Diff
Patch (1.39 KB, patch)
2013-09-03 12:12 PDT, Sergio Correia (qrwteyrutiyoup) 		no flags Details | Formatted Diff | Diff
Patch (1.49 KB, patch)
2013-09-04 14:16 PDT, Sergio Correia (qrwteyrutiyoup) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Correia (qrwteyrutiyoup) 2013-09-03 12:09:32 PDT 
[EFL] Move ShouldGoToBackForwardListItem to the list of passing WK2 API tests
Comment 1 Sergio Correia (qrwteyrutiyoup) 2013-09-03 12:10:11 PDT 
Since it currently (r154988) passes in both debug and release mode.
Comment 2 Sergio Correia (qrwteyrutiyoup) 2013-09-03 12:10:41 PDT 
Created attachment 210397 [details]
Patch
Comment 3 Sergio Correia (qrwteyrutiyoup) 2013-09-03 12:12:32 PDT 
Created attachment 210398 [details]
Patch

Added bug number to the ChangeLog.
Comment 4 Gyuyoung Kim 2013-09-03 18:02:05 PDT 
Comment on attachment 210398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210398&action=review

> Tools/ChangeLog:3
> +        [EFL] Move ShouldGoToBackForwardListItem to the list of passing WK2 API tests

It would be good to add [WK2] prefix as well.

> Tools/ChangeLog:8
> +        * TestWebKitAPI/PlatformEfl.cmake: Mark ShouldGoToBackForwardListItem as passing.

Do you know what revision this test was passed ?
Comment 5 Sergio Correia (qrwteyrutiyoup) 2013-09-04 14:16:03 PDT 
Created attachment 210494 [details]
Patch

Updated title and mentioned the revision in which the test started to pass.
Comment 6 Sergio Correia (qrwteyrutiyoup) 2013-09-04 14:17:26 PDT 
Updating bug title as per Gyuyoung's request.
Comment 7 WebKit Commit Bot 2013-09-04 18:21:49 PDT 
Comment on attachment 210494 [details]
Patch

Clearing flags on attachment: 210494

Committed r155085: <http://trac.webkit.org/changeset/155085>
Comment 8 WebKit Commit Bot 2013-09-04 18:21:52 PDT 
All reviewed patches have been landed.  Closing bug.