Bug 120639 - ASSERT in MarkedAllocator::allocateSlowCase is wrong
Summary: ASSERT in MarkedAllocator::allocateSlowCase is wrong
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
Depends on:
Reported: 2013-09-03 10:27 PDT by Mark Hahnenberg
Modified: 2013-09-04 14:01 PDT (History)
2 users (show)

See Also:

Patch (1.53 KB, patch)
2013-09-03 10:39 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-09-03 10:27:52 PDT
ASSERT(!m_heap->shouldCollect()) is no longer true due to our use of the GC deferral mechanism. We could technically be beyond our byte allocation limit, but still not try to collect due to deferral. We should either amend shouldCollect to account for GC deferral or remove this ASSERT.
Comment 1 Mark Hahnenberg 2013-09-03 10:39:43 PDT
Created attachment 210385 [details]
Comment 2 Mark Hahnenberg 2013-09-04 11:43:38 PDT
Comment 3 WebKit Commit Bot 2013-09-04 12:05:27 PDT
Comment on attachment 210385 [details]

Clearing flags on attachment: 210385

Committed r155056: <http://trac.webkit.org/changeset/155056>
Comment 4 WebKit Commit Bot 2013-09-04 12:05:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Benjamin Poulain 2013-09-04 14:01:35 PDT
The debug bots started crashing. E.g.: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r155055%20(12191)/results.html

It looks related to this change.
Can you please have a look?