Bug 120629 - [GTK][EFL] include missing localized string for subtitle auto track
Summary: [GTK][EFL] include missing localized string for subtitle auto track
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 117008
  Show dependency treegraph
 
Reported: 2013-09-03 05:17 PDT by Danilo Cesar Lemes de Paula
Modified: 2013-09-03 11:59 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.12 KB, patch)
2013-09-03 05:19 PDT, Danilo Cesar Lemes de Paula
no flags Details | Formatted Diff | Diff
Patch (3.12 KB, patch)
2013-09-03 06:27 PDT, Danilo Cesar Lemes de Paula
no flags Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2013-09-03 10:01 PDT, Danilo Cesar Lemes de Paula
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Danilo Cesar Lemes de Paula 2013-09-03 05:17:31 PDT
those methods are necessary to show the "Auto" track on webkitgtk
Comment 1 Danilo Cesar Lemes de Paula 2013-09-03 05:19:28 PDT
Created attachment 210355 [details]
Patch
Comment 2 Danilo Cesar Lemes de Paula 2013-09-03 06:27:56 PDT
Created attachment 210366 [details]
Patch
Comment 3 Danilo Cesar Lemes de Paula 2013-09-03 06:49:47 PDT
we need https://bugs.webkit.org/show_bug.cgi?id=117008 to be accepted first.
Comment 4 Danilo Cesar Lemes de Paula 2013-09-03 10:01:00 PDT
Created attachment 210380 [details]
Patch
Comment 5 Danilo Cesar Lemes de Paula 2013-09-03 10:18:18 PDT
This patch is necessary since CaptionUserPreferences will use those methods (as it already does for TrackOffMenuItemText())
Comment 6 WebKit Commit Bot 2013-09-03 11:59:07 PDT
Comment on attachment 210380 [details]
Patch

Clearing flags on attachment: 210380

Committed r154994: <http://trac.webkit.org/changeset/154994>
Comment 7 WebKit Commit Bot 2013-09-03 11:59:10 PDT
All reviewed patches have been landed.  Closing bug.