SSIA. Fun times.
Created attachment 210363 [details]
Comment on attachment 210363 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=210363&action=review
> + (gdk_screen_get_monitor_workarea): Additionally guard bits of code that depend on the GTK_WINDOWING_X11 macro being
> + AC_MSG_WARN([X11 target support not enabled, disabling GLX support.])
> + enable_glx=no
Perhaps this should only warn if enable_glx was true.
> +if test "$with_x11_target" != "yes" && test "$with_wayland_target" = "yes" && test "enable_accelerated_compositing" != "no"; then
I think it's weird how we test for != "yes", = "yes", != "no" quite inconsistently heh, just saying though, no need for changing.
> +# To support building for X11 and Wayland targets concurrently, the $with_target value is checked for this
> +# special case and two additional variables are introduced that denote specifically whether we're building
> +# the X11 target, the Wayland target, both of these or neither.
OK, I've tested builds with both Wayland-only target and the parallel X11+Wayland target - not as thoroughly as I would have liked, but that's still to come.
Either of the configurations fails gracefully under Wayland when confronted with a plugin, so that works. HTML5 video also works. The build with both targets enabled shows no regressions under X11.
I'll be landing this patch today and proceed with testing.
I also plan to fold the '#if defined(GDK_WINDOWING_X11)' checks into '#if PLATFORM(X11)' (and ditto for GDK_WINDOWING_WAYLAND -> PLATFORM(WAYLAND)), for the sake of simplifying these build guards.
Committed r155032: <http://trac.webkit.org/changeset/155032>