WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 120614
enable filter-build-webkit for logs on build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=120614
Summary
enable filter-build-webkit for logs on build.webkit.org
Lucas Forschler
Reported
2013-09-02 21:21:19 PDT
Enable Opensource/Tools/Scripts/filter-build-webkit on the log files
Attachments
Add a summary to the current stdio which captures errors and warnings
(1.91 KB, patch)
2013-09-12 12:55 PDT
,
Lucas Forschler
no flags
Details
Formatted Diff
Diff
Updated patch to filter logs. Make it platform mac only.
(2.05 KB, patch)
2013-09-12 15:31 PDT
,
Lucas Forschler
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Lucas Forschler
Comment 1
2013-09-02 21:32:03 PDT
Sadly, build-webkit output's to stdio, not to a file. So, doing this on the client in a follow-up step won't work, as there is no log on disk to operate on. However, I think we could probably do this server-side by using some stdio filtering. The createSummary function should work here.
Lucas Forschler
Comment 2
2013-09-12 12:55:29 PDT
Created
attachment 211459
[details]
Add a summary to the current stdio which captures errors and warnings
Lucas Forschler
Comment 3
2013-09-12 12:56:46 PDT
This patch will filter out warnings and errors. It does not use filter-build-webkit. I've tested this on my own master/slave test setup on MacOS. as long as the build.webkit.org machine has StringIO, it should be fine there.
Lucas Forschler
Comment 4
2013-09-12 15:31:01 PDT
Created
attachment 211483
[details]
Updated patch to filter logs. Make it platform mac only. use cStringIO instead of StringIO for performance. Enable this only for the mac platform.
WebKit Commit Bot
Comment 5
2013-09-12 16:02:18 PDT
Comment on
attachment 211483
[details]
Updated patch to filter logs. Make it platform mac only. Clearing flags on attachment: 211483 Committed
r155656
: <
http://trac.webkit.org/changeset/155656
>
WebKit Commit Bot
Comment 6
2013-09-12 16:02:21 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug