WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
120601
[BlackBerry] Remove LayerData::LayerProgram
https://bugs.webkit.org/show_bug.cgi?id=120601
Summary
[BlackBerry] Remove LayerData::LayerProgram
Arvid Nilsson
Reported
2013-09-02 06:18:20 PDT
These days, all layer contents are RGBA, so we don't need the BGRA shaders any more. The default setting of BGRA was only used by layers that wound up drawing display lists using BlackBerry::Platform::Graphics APIs anyway, and the display list code can take care of such details itself.
Attachments
Patch
(12.74 KB, patch)
2013-09-02 06:30 PDT
,
Arvid Nilsson
no flags
Details
Formatted Diff
Diff
Patch
(12.70 KB, patch)
2013-09-02 23:40 PDT
,
Arvid Nilsson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Arvid Nilsson
Comment 1
2013-09-02 06:30:14 PDT
Created
attachment 210280
[details]
Patch
Arvid Nilsson
Comment 2
2013-09-02 23:34:55 PDT
Comment on
attachment 210280
[details]
Patch Thanks Anders!
WebKit Commit Bot
Comment 3
2013-09-02 23:35:45 PDT
Comment on
attachment 210280
[details]
Patch Rejecting
attachment 210280
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 210280, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output:
http://webkit-queues.appspot.com/results/1691157
Arvid Nilsson
Comment 4
2013-09-02 23:40:28 PDT
Created
attachment 210326
[details]
Patch Removed Internally reviewed by section from ChangeLog, no internal review happened for this patch
WebKit Commit Bot
Comment 5
2013-09-03 00:28:18 PDT
Comment on
attachment 210326
[details]
Patch Clearing flags on attachment: 210326 Committed
r154971
: <
http://trac.webkit.org/changeset/154971
>
WebKit Commit Bot
Comment 6
2013-09-03 00:28:20 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug