Bug 120601 - [BlackBerry] Remove LayerData::LayerProgram
Summary: [BlackBerry] Remove LayerData::LayerProgram
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arvid Nilsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-02 06:18 PDT by Arvid Nilsson
Modified: 2013-09-03 00:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.74 KB, patch)
2013-09-02 06:30 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
Patch (12.70 KB, patch)
2013-09-02 23:40 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2013-09-02 06:18:20 PDT 
These days, all layer contents are RGBA, so we don't need the BGRA shaders any more. The default setting of BGRA was only used by layers that wound up drawing display lists using BlackBerry::Platform::Graphics APIs anyway, and the display list code can take care of such details itself.
Comment 1 Arvid Nilsson 2013-09-02 06:30:14 PDT 
Created attachment 210280 [details]
Patch
Comment 2 Arvid Nilsson 2013-09-02 23:34:55 PDT 
Comment on attachment 210280 [details]
Patch

Thanks Anders!
Comment 3 WebKit Commit Bot 2013-09-02 23:35:45 PDT 
Comment on attachment 210280 [details]
Patch

Rejecting attachment 210280 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 210280, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/1691157
Comment 4 Arvid Nilsson 2013-09-02 23:40:28 PDT 
Created attachment 210326 [details]
Patch

Removed Internally reviewed by section from ChangeLog, no internal review happened for this patch
Comment 5 WebKit Commit Bot 2013-09-03 00:28:18 PDT 
Comment on attachment 210326 [details]
Patch

Clearing flags on attachment: 210326

Committed r154971: <http://trac.webkit.org/changeset/154971>
Comment 6 WebKit Commit Bot 2013-09-03 00:28:20 PDT 
All reviewed patches have been landed.  Closing bug.