Bug 120594 – Remove redefined GL_COLOR_ATTACHMENT0_EXT

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: ANGLE

[ChangSeok Oh]

I saw compiler complained GL_COLOR_ATTACHMENT0_EXT is redefined like below while building with gles2 and egl options enabled.
 
CXX    Source/WebCore/platform/graphics/opengl/libWebCorePlatform_la-GraphicsContext3DOpenGLCommon.lo
CXX    Source/WebCore/platform/graphics/opengl/libPlatform_la-Extensions3DOpenGLCommon.lo
In file included from ../../Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:57:0:
../../Source/WebCore/platform/graphics/OpenGLESShims.h:47:0: warning: "GL_COLOR_ATTACHMENT0_EXT" redefined [enabled by default]
In file included from ../../Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h:37:0,
                 from ../../Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:36:
../../Source/ThirdParty/ANGLE/include/GLES2/gl2ext.h:578:0: note: this is the location of the previous definition
In file included from ../../Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:42:0:
../../Source/ThirdParty/ANGLE/include/GLES2/gl2ext.h:578:0: warning: "GL_COLOR_ATTACHMENT0_EXT" redefined [enabled by default]
In file included from ../../Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:40:0:
../../Source/WebCore/platform/graphics/OpenGLESShims.h:47:0: note: this is the location of the previous definition
CXXLD  libPlatform.la

[ChangSeok Oh]

Created attachment 210267 [details]
Patch

[Build Bot]

Comment on attachment 210267 [details]
Patch

Attachment 210267 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1659884

New failing tests:
fast/workers/termination-with-port-messages.html

[Build Bot]

Created attachment 210270 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[ChangSeok Oh]

(In reply to comment #3)
> Created an attachment (id=210270) [details]
> Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
> Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

False alarm. I don't believe this change affects mac port.