Bug 120581 – [GTK] Color of input button's text broken with recent gnome-themes-standard

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Claudio Saavedra]

Since this commit:

commit 30609ba766dd055f41002dcb813225d619b1d951
Author: Cosimo Cecchi <[e-mail]>
Date:   Sun Jun 16 17:37:36 2013 -0700

    Adapt to changes in GTK+ state propagation
    
    As GTK+ stopped propagating state flags to children, we can get rid of
    all the wildcard overrides for color: and [text,icon]-shadow properties.
    Also bump the required GTK+ version to git master.

The text in buttons (<input type="Submit">) is broken, and these are painted always white. Seems that this is somehow related to bug 118234 too.

We need this to be merged to the 2.2 branch too.

[Claudio Saavedra]

Created attachment 210449 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 210449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210449&action=review

Thanks!

> Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:96
> +    else if (widgetType == GTK_TYPE_BUTTON) {
>          gtk_widget_path_iter_add_class(path, 0, GTK_STYLE_CLASS_BUTTON);
> +        gtk_widget_path_iter_add_class(path, 1, "text-button");
> +    }

I guess we don't have image buttons in WebKit, so we can assume that web buttons are always text buttons.

[WebKit Commit Bot]

Comment on attachment 210449 [details]
Patch

Clearing flags on attachment: 210449

Committed r155039: <http://trac.webkit.org/changeset/155039>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.