Bug 120581 - [GTK] Color of input button's text broken with recent gnome-themes-standard
Summary: [GTK] Color of input button's text broken with recent gnome-themes-standard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-01 08:40 PDT by Claudio Saavedra
Modified: 2013-09-04 06:43 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.36 KB, patch)
2013-09-04 05:53 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2013-09-01 08:40:25 PDT 
Since this commit:

commit 30609ba766dd055f41002dcb813225d619b1d951
Author: Cosimo Cecchi <cosimoc@gnome.org>
Date:   Sun Jun 16 17:37:36 2013 -0700

    Adapt to changes in GTK+ state propagation
    
    As GTK+ stopped propagating state flags to children, we can get rid of
    all the wildcard overrides for color: and [text,icon]-shadow properties.
    Also bump the required GTK+ version to git master.

The text in buttons (<input type="Submit">) is broken, and these are painted always white. Seems that this is somehow related to bug 118234 too.

We need this to be merged to the 2.2 branch too.
Comment 1 Claudio Saavedra 2013-09-04 05:53:10 PDT 
Created attachment 210449 [details]
Patch
Comment 2 Carlos Garcia Campos 2013-09-04 05:57:10 PDT 
Comment on attachment 210449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210449&action=review

Thanks!

> Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:96
> +    else if (widgetType == GTK_TYPE_BUTTON) {
>          gtk_widget_path_iter_add_class(path, 0, GTK_STYLE_CLASS_BUTTON);
> +        gtk_widget_path_iter_add_class(path, 1, "text-button");
> +    }

I guess we don't have image buttons in WebKit, so we can assume that web buttons are always text buttons.
Comment 3 WebKit Commit Bot 2013-09-04 06:43:25 PDT 
Comment on attachment 210449 [details]
Patch

Clearing flags on attachment: 210449

Committed r155039: <http://trac.webkit.org/changeset/155039>
Comment 4 WebKit Commit Bot 2013-09-04 06:43:27 PDT 
All reviewed patches have been landed.  Closing bug.