RESOLVED FIXED 120580
EventHandler::m_frame should be a Frame&. 
https://bugs.webkit.org/show_bug.cgi?id=120580
Summary EventHandler::m_frame should be a Frame&.
Andreas Kling
Reported Sunday, September 1, 2013 4:33:52 PM UTC
EventHandler::m_frame should be a Frame&.
Attachments
Patch (79.07 KB, patch)
2013-09-01 08:35 PDT, Andreas Kling 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch (79.06 KB, patch)
2013-09-01 08:47 PDT, Andreas Kling 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (79.88 KB, patch)
2013-09-01 08:56 PDT, Andreas Kling 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (79.97 KB, patch)
2013-09-01 10:38 PDT, Andreas Kling 		darin: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 Sunday, September 1, 2013 4:35:01 PM UTC
Created attachment 210243 [details] Patch
Early Warning System Bot
Comment 2 Sunday, September 1, 2013 4:45:19 PM UTC
Comment on attachment 210243 [details] Patch Attachment 210243 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1658691
EFL EWS Bot
Comment 3 Sunday, September 1, 2013 4:45:33 PM UTC
Comment on attachment 210243 [details] Patch Attachment 210243 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1679456
Early Warning System Bot
Comment 4 Sunday, September 1, 2013 4:47:00 PM UTC
Comment on attachment 210243 [details] Patch Attachment 210243 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1661695
Andreas Kling
Comment 5 Sunday, September 1, 2013 4:47:15 PM UTC
Created attachment 210244 [details] Patch Fix touch events build.
EFL EWS Bot
Comment 6 Sunday, September 1, 2013 4:51:35 PM UTC
Comment on attachment 210244 [details] Patch Attachment 210244 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1603637
Early Warning System Bot
Comment 7 Sunday, September 1, 2013 4:53:36 PM UTC
Comment on attachment 210244 [details] Patch Attachment 210244 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1658697
Early Warning System Bot
Comment 8 Sunday, September 1, 2013 4:54:23 PM UTC
Comment on attachment 210244 [details] Patch Attachment 210244 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1656702
Andreas Kling
Comment 9 Sunday, September 1, 2013 4:56:42 PM UTC
Created attachment 210245 [details] Patch :|
EFL EWS Bot
Comment 10 Sunday, September 1, 2013 5:01:35 PM UTC
Comment on attachment 210245 [details] Patch Attachment 210245 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1675527
Early Warning System Bot
Comment 11 Sunday, September 1, 2013 5:01:38 PM UTC
Comment on attachment 210245 [details] Patch Attachment 210245 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1679464
Early Warning System Bot
Comment 12 Sunday, September 1, 2013 5:04:06 PM UTC
Comment on attachment 210245 [details] Patch Attachment 210245 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1657653
EFL EWS Bot
Comment 13 Sunday, September 1, 2013 5:08:34 PM UTC
Comment on attachment 210245 [details] Patch Attachment 210245 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1675529
Andreas Kling
Comment 14 Sunday, September 1, 2013 6:38:18 PM UTC
Created attachment 210249 [details] Patch
kov's GTK+ EWS bot
Comment 15 Sunday, September 1, 2013 6:50:58 PM UTC
Comment on attachment 210249 [details] Patch Attachment 210249 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1609676
Darin Adler
Comment 16 Sunday, September 1, 2013 8:25:10 PM UTC
Comment on attachment 210249 [details] Patch GTK build failure seems like a false positive.
WebKit Commit Bot
Comment 17 Sunday, September 1, 2013 8:52:19 PM UTC
Comment on attachment 210249 [details] Patch Rejecting attachment 210249 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 210249, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ventHandler.h patching file Source/WebCore/page/Frame.cpp patching file Source/WebCore/page/efl/EventHandlerEfl.cpp patching file Source/WebCore/page/gtk/EventHandlerGtk.cpp patching file Source/WebCore/page/mac/EventHandlerMac.mm patching file Source/WebCore/page/qt/EventHandlerQt.cpp patching file Source/WebCore/page/win/EventHandlerWin.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/1658747
Andreas Kling
Comment 18 Sunday, September 1, 2013 9:03:13 PM UTC
Committed r154947: <http://trac.webkit.org/changeset/154947>
Note You need to log in before you can comment on or make changes to this bug.