Bug 120580 - EventHandler::m_frame should be a Frame&.
Summary: EventHandler::m_frame should be a Frame&.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-01 08:33 PDT by Andreas Kling
Modified: 2013-09-01 13:03 PDT (History)
7 users (show)

See Also:

Attachments
Patch (79.07 KB, patch)
2013-09-01 08:35 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (79.06 KB, patch)
2013-09-01 08:47 PDT, Andreas Kling 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (79.88 KB, patch)
2013-09-01 08:56 PDT, Andreas Kling 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (79.97 KB, patch)
2013-09-01 10:38 PDT, Andreas Kling 		darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-01 08:33:52 PDT 
EventHandler::m_frame should be a Frame&.
Comment 1 Andreas Kling 2013-09-01 08:35:01 PDT 
Created attachment 210243 [details]
Patch
Comment 2 Early Warning System Bot 2013-09-01 08:45:19 PDT 
Comment on attachment 210243 [details]
Patch

Attachment 210243 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1658691
Comment 3 EFL EWS Bot 2013-09-01 08:45:33 PDT 
Comment on attachment 210243 [details]
Patch

Attachment 210243 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1679456
Comment 4 Early Warning System Bot 2013-09-01 08:47:00 PDT 
Comment on attachment 210243 [details]
Patch

Attachment 210243 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1661695
Comment 5 Andreas Kling 2013-09-01 08:47:15 PDT 
Created attachment 210244 [details]
Patch

Fix touch events build.
Comment 6 EFL EWS Bot 2013-09-01 08:51:35 PDT 
Comment on attachment 210244 [details]
Patch

Attachment 210244 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1603637
Comment 7 Early Warning System Bot 2013-09-01 08:53:36 PDT 
Comment on attachment 210244 [details]
Patch

Attachment 210244 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1658697
Comment 8 Early Warning System Bot 2013-09-01 08:54:23 PDT 
Comment on attachment 210244 [details]
Patch

Attachment 210244 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1656702
Comment 9 Andreas Kling 2013-09-01 08:56:42 PDT 
Created attachment 210245 [details]
Patch

:|
Comment 10 EFL EWS Bot 2013-09-01 09:01:35 PDT 
Comment on attachment 210245 [details]
Patch

Attachment 210245 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1675527
Comment 11 Early Warning System Bot 2013-09-01 09:01:38 PDT 
Comment on attachment 210245 [details]
Patch

Attachment 210245 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1679464
Comment 12 Early Warning System Bot 2013-09-01 09:04:06 PDT 
Comment on attachment 210245 [details]
Patch

Attachment 210245 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1657653
Comment 13 EFL EWS Bot 2013-09-01 09:08:34 PDT 
Comment on attachment 210245 [details]
Patch

Attachment 210245 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1675529
Comment 14 Andreas Kling 2013-09-01 10:38:18 PDT 
Created attachment 210249 [details]
Patch
Comment 15 kov's GTK+ EWS bot 2013-09-01 10:50:58 PDT 
Comment on attachment 210249 [details]
Patch

Attachment 210249 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1609676
Comment 16 Darin Adler 2013-09-01 12:25:10 PDT 
Comment on attachment 210249 [details]
Patch

GTK build failure seems like a false positive.
Comment 17 WebKit Commit Bot 2013-09-01 12:52:19 PDT 
Comment on attachment 210249 [details]
Patch

Rejecting attachment 210249 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 210249, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ventHandler.h
patching file Source/WebCore/page/Frame.cpp
patching file Source/WebCore/page/efl/EventHandlerEfl.cpp
patching file Source/WebCore/page/gtk/EventHandlerGtk.cpp
patching file Source/WebCore/page/mac/EventHandlerMac.mm
patching file Source/WebCore/page/qt/EventHandlerQt.cpp
patching file Source/WebCore/page/win/EventHandlerWin.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/1658747
Comment 18 Andreas Kling 2013-09-01 13:03:13 PDT 
Committed r154947: <http://trac.webkit.org/changeset/154947>