RESOLVED FIXED 120579
HitTestResult should have innerNonSharedElement 
https://bugs.webkit.org/show_bug.cgi?id=120579
Summary HitTestResult should have innerNonSharedElement
Darin Adler
Reported 2013-09-01 07:32:06 PDT
HitTestResult should have innerNonSharedElement
Attachments
Patch (13.44 KB, patch)
2013-09-01 07:37 PDT, Darin Adler 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-09-01 07:36:51 PDT
Mr. Kling encouraged me to do this with a comment on my last patch.
Darin Adler
Comment 2 2013-09-01 07:37:42 PDT
Created attachment 210240 [details] Patch
Andreas Kling
Comment 3 2013-09-01 07:41:17 PDT
Comment on attachment 210240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210240&action=review r=me > Source/WebCore/ChangeLog:14 > + the node and chenking if it's an input element. Also added some missing braces. Typo, checking. > Source/WebCore/page/Chrome.cpp:439 > + if (Node* element = result.innerNonSharedElement()) { You should use an Element* pointer here.
Darin Adler
Comment 4 2013-09-01 12:11:25 PDT
Committed r154945: <http://trac.webkit.org/changeset/154945>
Note You need to log in before you can comment on or make changes to this bug.