Bug 120579 - HitTestResult should have innerNonSharedElement
Summary: HitTestResult should have innerNonSharedElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-01 07:32 PDT by Darin Adler
Modified: 2013-09-01 12:11 PDT (History)
1 user (show)

See Also:

Attachments
Patch (13.44 KB, patch)
2013-09-01 07:37 PDT, Darin Adler 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-09-01 07:32:06 PDT 
HitTestResult should have innerNonSharedElement
Comment 1 Darin Adler 2013-09-01 07:36:51 PDT 
Mr. Kling encouraged me to do this with a comment on my last patch.
Comment 2 Darin Adler 2013-09-01 07:37:42 PDT 
Created attachment 210240 [details]
Patch
Comment 3 Andreas Kling 2013-09-01 07:41:17 PDT 
Comment on attachment 210240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210240&action=review

r=me

> Source/WebCore/ChangeLog:14
> +        the node and chenking if it's an input element. Also added some missing braces.

Typo, checking.

> Source/WebCore/page/Chrome.cpp:439
> +        if (Node* element = result.innerNonSharedElement()) {

You should use an Element* pointer here.
Comment 4 Darin Adler 2013-09-01 12:11:25 PDT 
Committed r154945: <http://trac.webkit.org/changeset/154945>