RESOLVED FIXED 120574
Give EditCommand a protected Frame& getter. 
https://bugs.webkit.org/show_bug.cgi?id=120574
Summary Give EditCommand a protected Frame& getter.
Andreas Kling
Reported 2013-08-31 22:43:29 PDT
Going through document().frame()->xxx looks awkward, and we already know that there's always a Frame.
Attachments
Patch (18.26 KB, patch)
2013-08-31 22:44 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-08-31 22:44:28 PDT
Created attachment 210230 [details] Patch
WebKit Commit Bot
Comment 2 2013-09-01 07:56:18 PDT
Comment on attachment 210230 [details] Patch Clearing flags on attachment: 210230 Committed r154943: <http://trac.webkit.org/changeset/154943>
WebKit Commit Bot
Comment 3 2013-09-01 07:56:20 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2013-09-01 09:46:37 PDT
Comment on attachment 210230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210230&action=review > Source/WebCore/ChangeLog:8 > + EditCommand is only created for documents that are attached to a Frame, Is this actually so? Are they not created for document.execCommand?
Andreas Kling
Comment 5 2013-09-01 09:54:14 PDT
Comment on attachment 210230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210230&action=review >> Source/WebCore/ChangeLog:8 >> + EditCommand is only created for documents that are attached to a Frame, > > Is this actually so? Are they not created for document.execCommand? Document::execCommand() creates (and executes) a no-op Editor::Command if Document is not attached to a Frame.
Note You need to log in before you can comment on or make changes to this bug.