Bug 120574 - Give EditCommand a protected Frame& getter.
Summary: Give EditCommand a protected Frame& getter.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-31 22:43 PDT by Andreas Kling
Modified: 2013-09-01 09:54 PDT (History)
3 users (show)

See Also:

Attachments
Patch (18.26 KB, patch)
2013-08-31 22:44 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-31 22:43:29 PDT 
Going through document().frame()->xxx looks awkward, and we already know that there's always a Frame.
Comment 1 Andreas Kling 2013-08-31 22:44:28 PDT 
Created attachment 210230 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-01 07:56:18 PDT 
Comment on attachment 210230 [details]
Patch

Clearing flags on attachment: 210230

Committed r154943: <http://trac.webkit.org/changeset/154943>
Comment 3 WebKit Commit Bot 2013-09-01 07:56:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2013-09-01 09:46:37 PDT 
Comment on attachment 210230 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210230&action=review

> Source/WebCore/ChangeLog:8
> +        EditCommand is only created for documents that are attached to a Frame,

Is this actually so? Are they not created for document.execCommand?
Comment 5 Andreas Kling 2013-09-01 09:54:14 PDT 
Comment on attachment 210230 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210230&action=review

>> Source/WebCore/ChangeLog:8
>> +        EditCommand is only created for documents that are attached to a Frame,
> 
> Is this actually so? Are they not created for document.execCommand?

Document::execCommand() creates (and executes) a no-op Editor::Command if Document is not attached to a Frame.