RESOLVED FIXED 120573
Refactor URL and image writing so layer-violating parts are in Editor, not Pasteboard (Mac-only at first) 
https://bugs.webkit.org/show_bug.cgi?id=120573
Summary Refactor URL and image writing so layer-violating parts are in Editor, not Pa...
Darin Adler
Reported 2013-08-31 22:35:36 PDT
Refactor URL and image writing so layer-violating parts are in Editor, not Pasteboard (Mac-only at first)
Attachments
Patch (18.40 KB, patch)
2013-08-31 22:42 PDT, Darin Adler 		kling: review+
kling: commit-queue+
DetailsFormatted DiffDiff
don't use cachedImage without initialization (793 bytes, patch)
2013-09-01 08:05 PDT, Tobias Netzel 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-08-31 22:42:46 PDT
Created attachment 210229 [details] Patch
Andreas Kling
Comment 2 2013-08-31 23:01:37 PDT
Comment on attachment 210229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210229&action=review > Source/WebCore/editing/Editor.cpp:1173 > +// FIXME: Should this be a member function of HitTestResult? I'd say so.
Darin Adler
Comment 3 2013-08-31 23:25:06 PDT
Committed r154939: <http://trac.webkit.org/changeset/154939>
Tobias Netzel
Comment 4 2013-09-01 08:05:52 PDT
Created attachment 210242 [details] don't use cachedImage without initialization Didn't compile here on mac because of using cachedImage without initializing it. I guess you meant it to be as in the attached patch. It's just for your info so you may include that in a follow-up patch.
Darin Adler
Comment 6 2013-09-01 12:15:04 PDT
Comment on attachment 210242 [details] don't use cachedImage without initialization Those look like good changes. Let me take care of this.
Darin Adler
Comment 7 2013-09-01 12:18:29 PDT
I think the crash is caused by the same thing that Tobias Netzel repotted.
Note You need to log in before you can comment on or make changes to this bug.