Bug 120572 – ASSERT if port don't have color picker implemenation by inheriting webcolorpicker

• Status: UNCONFIRMED
• Component: Forms

[Santosh Mahto]

Crash happens if port don't have implementation by inheriting WebColorPicker as happening in EFL port.

[Santosh Mahto]

Created attachment 210228 [details]
Patch

[Darin Adler]

Comment on attachment 210228 [details]
Patch

I don’t understand the point of this.

[Darin Adler]

Comment on attachment 210228 [details]
Patch

This is not a useful assertion. Don’t turn on INPUT_TYPE_COLOR without implementing createColorPicker. An assertion is not a helpful way to go further with this. The null dereference happens on the next line of code!

[Santosh Mahto]

(In reply to comment #3)
> (From update of attachment 210228 [details])
> This is not a useful assertion. Don’t turn on INPUT_TYPE_COLOR without implementing createColorPicker. An assertion is not a helpful way to go further with this. The null dereference happens on the next line of code!

 WK2 ports implement color picker as two way.
1. inherit WebColorPicker  --> 

2. register PageUIClient Callback   --> Currently EFL port has this and m_colorPicke return null and its crashing now. [EFL]https://bugs.webkit.org/show_bug.cgi?id=119120 try to move the implementaion accoroding to first procedure.

I had a thought 
we should put a assert  to have m_colorpicker at that point.
OR we can avoid crash by having null check
OR wait for 119120 to land 

What is your view??