Bug 120572 - ASSERT if port don't have color picker implemenation by inheriting webcolorpicker
Summary: ASSERT if port don't have color picker implemenation by inheriting webcolorpi...
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-31 22:26 PDT by Santosh Mahto
Modified: 2013-09-01 07:40 PDT (History)
0 users

See Also:


Attachments
Patch (1.44 KB, patch)
2013-08-31 22:29 PDT, Santosh Mahto
darin: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Santosh Mahto 2013-08-31 22:26:16 PDT
Crash happens if port don't have implementation by inheriting WebColorPicker as happening in EFL port.
Comment 1 Santosh Mahto 2013-08-31 22:29:50 PDT
Created attachment 210228 [details]
Patch
Comment 2 Darin Adler 2013-09-01 07:16:33 PDT
Comment on attachment 210228 [details]
Patch

I don’t understand the point of this.
Comment 3 Darin Adler 2013-09-01 07:17:31 PDT
Comment on attachment 210228 [details]
Patch

This is not a useful assertion. Don’t turn on INPUT_TYPE_COLOR without implementing createColorPicker. An assertion is not a helpful way to go further with this. The null dereference happens on the next line of code!
Comment 4 Santosh Mahto 2013-09-01 07:40:57 PDT
(In reply to comment #3)
> (From update of attachment 210228 [details])
> This is not a useful assertion. Don’t turn on INPUT_TYPE_COLOR without implementing createColorPicker. An assertion is not a helpful way to go further with this. The null dereference happens on the next line of code!

 WK2 ports implement color picker as two way.
1. inherit WebColorPicker  --> 

2. register PageUIClient Callback   --> Currently EFL port has this and m_colorPicke return null and its crashing now. [EFL]https://bugs.webkit.org/show_bug.cgi?id=119120 try to move the implementaion accoroding to first procedure.

I had a thought 
we should put a assert  to have m_colorpicker at that point.
OR we can avoid crash by having null check
OR wait for 119120 to land 

What is your view??