WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
120568
DeferredRefCounted should have a thread-safe mode
https://bugs.webkit.org/show_bug.cgi?id=120568
Summary
DeferredRefCounted should have a thread-safe mode
Filip Pizlo
Reported
2013-08-31 17:45:50 PDT
Needed for
https://bugs.webkit.org/show_bug.cgi?id=120567
.
Attachments
the patch
(3.71 KB, patch)
2013-08-31 17:47 PDT
,
Filip Pizlo
no flags
Details
Formatted Diff
Diff
the patch
(19.55 KB, patch)
2013-08-31 21:14 PDT
,
Filip Pizlo
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2013-08-31 17:47:21 PDT
Created
attachment 210221
[details]
the patch
WebKit Commit Bot
Comment 2
2013-08-31 17:49:15 PDT
Attachment 210221
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/DeferrableRefCounted.h']" exit_code: 1 Source/WTF/wtf/DeferrableRefCounted.h:58: Semicolon defining empty statement for this loop. Use { } instead. [whitespace/semicolon] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3
2013-08-31 17:49:43 PDT
(In reply to
comment #2
)
>
Attachment 210221
[details]
did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/DeferrableRefCounted.h']" exit_code: 1 > Source/WTF/wtf/DeferrableRefCounted.h:58: Semicolon defining empty statement for this loop. Use { } instead. [whitespace/semicolon] [5]
Fixed.
> Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 4
2013-08-31 21:05:15 PDT
Comment on
attachment 210221
[details]
the patch Clearing r+ because I found some performance issues.
Filip Pizlo
Comment 5
2013-08-31 21:14:44 PDT
Created
attachment 210223
[details]
the patch
Filip Pizlo
Comment 6
2013-09-01 09:40:10 PDT
Comment on
attachment 210223
[details]
the patch Never mind.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug