Bug 120553 - Volume slider value should be 0 when audio is muted
Summary: Volume slider value should be 0 when audio is muted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-30 15:11 PDT by Xabier Rodríguez Calvar
Modified: 2013-09-01 10:11 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.64 KB, patch)
2013-08-30 15:17 PDT, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff
Patch (6.78 KB, patch)
2013-08-31 13:53 PDT, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (584.40 KB, application/zip)
2013-08-31 15:04 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (594.54 KB, application/zip)
2013-08-31 16:08 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (1.27 MB, application/zip)
2013-08-31 18:42 PDT, Build Bot
no flags Details
Patch (9.58 KB, patch)
2013-09-01 02:27 PDT, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2013-08-30 15:11:37 PDT
Volume slider value should be 0 when audio is muted
Comment 1 Xabier Rodríguez Calvar 2013-08-30 15:17:47 PDT
Created attachment 210167 [details]
Patch

Set the slider value to 0 when audio is muted.
Comment 2 Eric Carlson 2013-08-30 15:31:10 PDT
Comment on attachment 210167 [details]
Patch

This looks OK, but it should be testable.
Comment 3 Xabier Rodríguez Calvar 2013-08-30 16:21:57 PDT
(In reply to comment #2)
> (From update of attachment 210167 [details])
> This looks OK, but it should be testable.

I'll write a test as soon as I can. Thanks!
Comment 4 Xabier Rodríguez Calvar 2013-08-31 13:53:01 PDT
Created attachment 210213 [details]
Patch

Added test.
Comment 5 Build Bot 2013-08-31 15:04:06 PDT
Comment on attachment 210213 [details]
Patch

Attachment 210213 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1679229

New failing tests:
media/video-volume-slider.html
media/volume-bar-empty-when-muted.html
Comment 6 Build Bot 2013-08-31 15:04:08 PDT
Created attachment 210218 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.4
Comment 7 Eric Carlson 2013-08-31 15:11:29 PDT
Comment on attachment 210213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210213&action=review

> Source/WebCore/html/shadow/MediaControls.cpp:111
> -            m_volumeSlider->setVolume(m_mediaController->volume());
> +            setSliderVolume();

It looks like you need to make this same change to MediaControlsApple::reset. I assume this is what makes the new test fail on the Mac bots.

> LayoutTests/media/video-volume-slider.html:42
> +    volume slider is implemented and mouse over the right bottom corner of<br>

Nice catch. Don't the results for this test also need to be updated?
Comment 8 Build Bot 2013-08-31 16:08:29 PDT
Comment on attachment 210213 [details]
Patch

Attachment 210213 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1642400

New failing tests:
media/video-volume-slider.html
media/volume-bar-empty-when-muted.html
Comment 9 Build Bot 2013-08-31 16:08:32 PDT
Created attachment 210220 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.4
Comment 10 Build Bot 2013-08-31 18:42:31 PDT
Comment on attachment 210213 [details]
Patch

Attachment 210213 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1603458

New failing tests:
editing/unsupported-content/table-delete-003.html
editing/unsupported-content/list-type-before.html
media/video-volume-slider.html
editing/unsupported-content/table-type-before.html
editing/unsupported-content/list-delete-003.html
media/volume-bar-empty-when-muted.html
editing/unsupported-content/list-delete-001.html
editing/unsupported-content/list-type-after.html
editing/unsupported-content/table-delete-002.html
editing/unsupported-content/table-type-after.html
editing/unsupported-content/table-delete-001.html
Comment 11 Build Bot 2013-08-31 18:42:33 PDT
Created attachment 210222 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4
Comment 12 Xabier Rodríguez Calvar 2013-09-01 01:35:55 PDT
(In reply to comment #7)
> > LayoutTests/media/video-volume-slider.html:42
> > +    volume slider is implemented and mouse over the right bottom corner of<br>
> 
> Nice catch. Don't the results for this test also need to be updated?

Yes, they do. I think I'll file another bug and fix it unreviewed. I'll CC you anyway.
Comment 13 Xabier Rodríguez Calvar 2013-09-01 02:27:17 PDT
Created attachment 210233 [details]
Patch

Fixed Apple problem, updated Blackberry and removed the typo that shall be corrected in another bug.
Comment 14 Eric Carlson 2013-09-01 09:17:49 PDT
Comment on attachment 210233 [details]
Patch

Thanks!
Comment 15 WebKit Commit Bot 2013-09-01 10:11:15 PDT
Comment on attachment 210233 [details]
Patch

Clearing flags on attachment: 210233

Committed r154944: <http://trac.webkit.org/changeset/154944>
Comment 16 WebKit Commit Bot 2013-09-01 10:11:19 PDT
All reviewed patches have been landed.  Closing bug.