RESOLVED FIXED 120540
Use Element& in StyleResolveTree 
https://bugs.webkit.org/show_bug.cgi?id=120540
Summary Use Element& in StyleResolveTree
Antti Koivisto
Reported 2013-08-30 10:59:03 PDT
*->&
Attachments
patch (39.84 KB, patch)
2013-08-30 11:17 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-08-30 11:17:10 PDT
Created attachment 210137 [details] patch
Andreas Kling
Comment 2 2013-08-30 11:23:47 PDT
Comment on attachment 210137 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=210137&action=review r=me. Obligatory whining about places where reasons for dereference safety is not immediately clear: > Source/WebCore/dom/ContainerNode.cpp:108 > static inline void attachChild(Node* child) This should take a Node&. > Source/WebCore/dom/ContainerNode.cpp:116 > static inline void detachChild(Node* child) This should take a Node&. > Source/WebCore/dom/Element.cpp:2303 > + Style::resolveTree(*existingPseudoElement, needsStyleRecalc() ? Style::Force : change); This function should take a PseudoElement& instead of a PseudoElement*. > Source/WebCore/style/StyleResolveTree.cpp:472 > + PostAttachCallbackDisabler callbackDisabler(&current); We should make this RAII object take a ContainerNode& instead.
Antti Koivisto
Comment 3 2013-08-30 11:43:28 PDT
https://trac.webkit.org/r154903
Note You need to log in before you can comment on or make changes to this bug.