SynchronousLoaderClient::didReceiveAuthenticationChallengedidReceiveAuthenticationChallenge() is guarded by USE(CFNETWORK) in Source/WebCore/platform/network/SynchronousLoaderClient.cpp, but isn't in its header. It causes link failure on !CF platforms with enabled NetworkProcess. Guarding this function is safe, because it is implemented in the base class of SynchronousLoaderClient by ResourceHandleClient. (It is an empty function.)
Created attachment 210121 [details] Patch
Comment on attachment 210121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210121&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Commit queue can’t handle a patch that has a line like this in it.
Committed r154891: <http://trac.webkit.org/changeset/154891>
This broke the Mac build http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20%28Build%29/builds/15596/steps/compile-webkit/logs/stdio /Volumes/Data/slave/mountainlion-debug/build/Source/WebCore/platform/network/mac/SynchronousLoaderClient.mm:35:31: error: out-of-line definition of 'didReceiveAuthenticationChallenge' does not match any declaration in 'WebCore::SynchronousLoaderClient' void SynchronousLoaderClient::didReceiveAuthenticationChallenge(ResourceHandle*, const AuthenticationChallenge& challenge) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.
Re-opened since this is blocked by bug 120539
Sorry for the breakage, I rolled it out for now, will fix a little bit later.
Created attachment 210133 [details] patch-for-ews patch for EWS
*** Bug 120533 has been marked as a duplicate of this bug. ***
Created attachment 210271 [details] patch-for-ews CFNETWORK implementation of SynchronousLoaderClient::didReceiveAuthenticationChallenge() and SynchronousLoaderClient::platformBadResponseError() shouldn't be in the cross-platform SynchronousLoaderClient.cpp, but in cf/SynchronousLoaderClientCFNet.cpp
Comment on attachment 210271 [details] patch-for-ews EWS bots are happy, so r? for this patch.
Ping
Comment on attachment 210271 [details] patch-for-ews View in context: https://bugs.webkit.org/attachment.cgi?id=210271&action=review > Source/WebCore/platform/network/cf/SynchronousLoaderClientCFNet.cpp:34 > +#if USE(CFNETWORK) > +#include <CFNetwork/CFURLConnectionPriv.h> > +#endif If this entire file is only for CFNetwork, then why the #if? If we do have an #if, it should wrap the whole file, not just the functions and this one include.
Created attachment 210492 [details] Patch I used #if guards similar to other *CFNet.cpp. But you're right, guarding the whole file is reasonable, so I fixed it.
Comment on attachment 210492 [details] Patch Clearing flags on attachment: 210492 Committed r155108: <http://trac.webkit.org/changeset/155108>
All reviewed patches have been landed. Closing bug.