Bug 120527 - StyleResolver & friends should use Document&.
Summary: StyleResolver & friends should use Document&.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-30 07:47 PDT by Andreas Kling
Modified: 2013-09-02 05:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch for EWS (39.68 KB, patch)
2013-08-30 07:54 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (41.89 KB, patch)
2013-08-30 08:17 PDT, Andreas Kling 		koivisto: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (44.99 KB, patch)
2013-08-30 08:46 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-30 07:47:21 PDT 
StyleResolver & friends should use Document&.
Comment 1 Andreas Kling 2013-08-30 07:54:51 PDT 
Created attachment 210109 [details]
Patch for EWS
Comment 2 Early Warning System Bot 2013-08-30 08:05:22 PDT 
Comment on attachment 210109 [details]
Patch for EWS

Attachment 210109 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1635570
Comment 3 Early Warning System Bot 2013-08-30 08:05:44 PDT 
Comment on attachment 210109 [details]
Patch for EWS

Attachment 210109 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1646120
Comment 4 Build Bot 2013-08-30 08:17:09 PDT 
Comment on attachment 210109 [details]
Patch for EWS

Attachment 210109 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1588489
Comment 5 Andreas Kling 2013-08-30 08:17:54 PDT 
Created attachment 210113 [details]
Patch
Comment 6 Build Bot 2013-08-30 08:22:38 PDT 
Comment on attachment 210113 [details]
Patch

Attachment 210113 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1648122
Comment 7 Early Warning System Bot 2013-08-30 08:30:02 PDT 
Comment on attachment 210113 [details]
Patch

Attachment 210113 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1654104
Comment 8 Early Warning System Bot 2013-08-30 08:33:33 PDT 
Comment on attachment 210113 [details]
Patch

Attachment 210113 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1633113
Comment 9 Andreas Kling 2013-08-30 08:46:11 PDT 
Created attachment 210115 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2013-08-30 09:17:06 PDT 
Comment on attachment 210115 [details]
Patch for landing

Clearing flags on attachment: 210115

Committed r154887: <http://trac.webkit.org/changeset/154887>
Comment 11 WebKit Commit Bot 2013-08-30 09:17:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Csaba Osztrogonác 2013-08-30 10:40:55 PDT 
(In reply to comment #10)
> (From update of attachment 210115 [details])
> Clearing flags on attachment: 210115
> 
> Committed r154887: <http://trac.webkit.org/changeset/154887>

FYI: It broke the GTK and EFL builds.
Comment 13 Csaba Osztrogonác 2013-09-02 05:15:05 PDT 
(In reply to comment #12)
> (In reply to comment #10)
> > (From update of attachment 210115 [details] [details])
> > Clearing flags on attachment: 210115
> > 
> > Committed r154887: <http://trac.webkit.org/changeset/154887>
> 
> FYI: It broke the GTK and EFL builds.

Fix landed in http://trac.webkit.org/changeset/154894