Bug 120524 - Compile warning fix: In graphics/cairo/GraphicsContextCairo.cpp.
Summary: Compile warning fix: In graphics/cairo/GraphicsContextCairo.cpp.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-30 06:27 PDT by Gábor Ábrahám
Modified: 2013-09-06 04:39 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (1.44 KB, patch)
2013-08-30 06:29 PDT, Gábor Ábrahám 		no flags Details | Formatted Diff | Diff
Fixed patch (1.42 KB, patch)
2013-08-30 08:48 PDT, Gábor Ábrahám 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gábor Ábrahám 2013-08-30 06:27:25 PDT 
In Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
There is an unused parameter in GraphicsContext::fillRectWithRoundedHole function.
Comment 1 Gábor Ábrahám 2013-08-30 06:29:50 PDT 
Created attachment 210098 [details]
Proposed patch
Comment 2 Darin Adler 2013-08-30 08:01:48 PDT 
Comment on attachment 210098 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210098&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Commit queue won’t land a patch with the word OOPS in it.
Comment 3 WebKit Commit Bot 2013-08-30 08:24:23 PDT 
Comment on attachment 210098 [details]
Proposed patch

Rejecting attachment 210098 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 210098, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/1648125
Comment 4 Gábor Ábrahám 2013-08-30 08:48:35 PDT 
Created attachment 210116 [details]
Fixed patch
Comment 5 WebKit Commit Bot 2013-08-30 09:38:10 PDT 
Comment on attachment 210116 [details]
Fixed patch

Clearing flags on attachment: 210116

Committed r154888: <http://trac.webkit.org/changeset/154888>