Bug 120522 - Resolve unused parameter warning in WebProcessProxy.cpp
Summary: Resolve unused parameter warning in WebProcessProxy.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-30 05:16 PDT by Tamas Czene
Modified: 2014-02-13 09:33 PST (History)
5 users (show)

See Also:


Attachments
proposed patch (1.11 KB, patch)
2013-08-30 05:17 PDT, Tamas Czene
no flags Details | Formatted Diff | Diff
proposed patch (1.11 KB, patch)
2013-08-30 05:37 PDT, Tamas Czene
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Czene 2013-08-30 05:16:47 PDT
Resolve unused parameter warning in WebProcessProxy.cpp
Comment 1 Tamas Czene 2013-08-30 05:17:49 PDT
Created attachment 210090 [details]
proposed patch
Comment 2 Early Warning System Bot 2013-08-30 05:23:07 PDT
Comment on attachment 210090 [details]
proposed patch

Attachment 210090 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1582492
Comment 3 EFL EWS Bot 2013-08-30 05:31:35 PDT
Comment on attachment 210090 [details]
proposed patch

Attachment 210090 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1635539
Comment 4 Tamas Czene 2013-08-30 05:37:23 PDT
Created attachment 210091 [details]
proposed patch
Comment 5 WebKit Commit Bot 2013-08-30 05:57:35 PDT
Comment on attachment 210091 [details]
proposed patch

Rejecting attachment 210091 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 210091, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit2/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/1633068
Comment 6 Csaba Osztrogonác 2014-02-13 04:05:10 PST
Comment on attachment 210090 [details]
proposed patch

Cleared Andreas Kling's review+ from obsolete attachment 210090 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 7 Alexey Proskuryakov 2014-02-13 09:33:50 PST
This fix is now in the trunk (possibly someone else redid it)?