Bug 120516 - Resolve unused parameter warning in FindController.cpp
Summary: Resolve unused parameter warning in FindController.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-30 01:56 PDT by Tamas Czene
Modified: 2013-08-30 08:24 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (1.35 KB, patch)
2013-08-30 01:57 PDT, Tamas Czene 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Czene 2013-08-30 01:56:24 PDT 
Resolve unused parameter warning in FindController.cpp
Comment 1 Tamas Czene 2013-08-30 01:57:56 PDT 
Created attachment 210079 [details]
proposed patch
Comment 2 Darin Adler 2013-08-30 08:00:12 PDT 
Comment on attachment 210079 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210079&action=review

> Source/WebKit2/WebProcess/WebPage/FindController.cpp:397
> +void FindController::drawRect(PageOverlay* /*pageOverlay*/, GraphicsContext& graphicsContext, const IntRect& dirtyRect)

Should remove the argument name entirely. There is no information conveyed by a commented-out name that repeats the type.
Comment 3 WebKit Commit Bot 2013-08-30 08:24:22 PDT 
Comment on attachment 210079 [details]
proposed patch

Clearing flags on attachment: 210079

Committed r154883: <http://trac.webkit.org/changeset/154883>
Comment 4 WebKit Commit Bot 2013-08-30 08:24:25 PDT 
All reviewed patches have been landed.  Closing bug.