WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
120515
Resolve unused parameter warning in WebPlatformStrategies.cpp
https://bugs.webkit.org/show_bug.cgi?id=120515
Summary
Resolve unused parameter warning in WebPlatformStrategies.cpp
Tamas Czene
Reported
2013-08-30 01:49:40 PDT
Resolve unused parameter warning in WebPlatformStrategies.cpp
Attachments
proposed patch
(1.36 KB, patch)
2013-08-30 01:51 PDT
,
Tamas Czene
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tamas Czene
Comment 1
2013-08-30 01:51:42 PDT
Created
attachment 210078
[details]
proposed patch
Darin Adler
Comment 2
2013-08-30 07:59:37 PDT
Comment on
attachment 210078
[details]
proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=210078&action=review
> Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp:100 > +void TapHighlightController::drawRect(PageOverlay* /*pageOverlay*/, GraphicsContext& context, const IntRect& /*dirtyRect*/)
Should remove the argument entirely. No need for the commented out word "pageOverlay"; it doesn’t document anything.
WebKit Commit Bot
Comment 3
2013-08-30 08:24:48 PDT
Comment on
attachment 210078
[details]
proposed patch Clearing flags on attachment: 210078 Committed
r154884
: <
http://trac.webkit.org/changeset/154884
>
WebKit Commit Bot
Comment 4
2013-08-30 08:24:49 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug