Bug 120481 - REGRESSION(r154821): Broke non-DFG build. StackIterator::Frame::setToEnd() should not be conditional on #if ENABLE(DFG_JIT). (Requested by bfulgham on #webkit).
Summary: REGRESSION(r154821): Broke non-DFG build. StackIterator::Frame::setToEnd() sh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords:
Depends on:
Blocks: 119657
  Show dependency tree / graph
 
Reported: 2013-08-29 11:31 PDT by WebKit Commit Bot
Modified: 2013-08-29 12:06 PDT (History)
2 users (show)

See Also:

Attachments
ROLLOUT of r154821 (31.86 KB, patch)
2013-08-29 11:31 PDT, WebKit Commit Bot 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2013-08-29 11:31:28 PDT 
http://trac.webkit.org/changeset/154821 broke the build:
Broke Windows build. Assumes 'setToEnd' part of StackIterator::Frame on Windows. (Requested by bfulgham on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2013-08-29 11:31:53 PDT 
Created attachment 210006 [details]
ROLLOUT of r154821

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Mark Lam 2013-08-29 11:43:43 PDT 
Landed a gardening fix in r154827: <http://trac.webkit.org/r154827>.

Basically, StackIterator::Frame::setToEnd() is not supposed to be conditional on #if ENABLE(DFG_JIT).  The fix is simply to remove the #if ENABLE(DFG_JIT).
Comment 3 Mark Lam 2013-08-29 12:04:36 PDT 
The Windows bots are green after landing r154827.  Closing as fixed.