RESOLVED FIXED 120474
Follow-up to r154810 and r154810: Missing tests and fix one misplaced call to setCaptionDisplayMode 
https://bugs.webkit.org/show_bug.cgi?id=120474
Summary Follow-up to r154810 and r154810: Missing tests and fix one misplaced call to...
Simon Pena
Reported 2013-08-29 08:59:04 PDT
I used a simple regular expression to identify the tests missing the call to setCaptionDisplay mode, git grep 'kind="captions" .* default>' so I missed several other occurrences of this issue. I now added git grep -l -e "default.*captions.*>" and git grep -l -e "captions.*default.*>" Besides, in media/track/track-cue-rendering-on-resize.html, I added setCaptionDisplayMode before the method is defined by video-test.js, so it wouldn't work. The new patch coming hopefully addresses all this issues.
Attachments
Patch (12.44 KB, patch)
2013-08-29 09:13 PDT, Simon Pena 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Pena
Comment 1 2013-08-29 09:13:05 PDT
Created attachment 209989 [details] Patch
WebKit Commit Bot
Comment 2 2013-08-29 09:40:25 PDT
Comment on attachment 209989 [details] Patch Clearing flags on attachment: 209989 Committed r154815: <http://trac.webkit.org/changeset/154815>
WebKit Commit Bot
Comment 3 2013-08-29 09:40:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.