Bug 120474 - Follow-up to r154810 and r154810: Missing tests and fix one misplaced call to setCaptionDisplayMode
Summary: Follow-up to r154810 and r154810: Missing tests and fix one misplaced call to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Pena
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-29 08:59 PDT by Simon Pena
Modified: 2013-08-29 09:40 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.44 KB, patch)
2013-08-29 09:13 PDT, Simon Pena 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pena 2013-08-29 08:59:04 PDT 
I used a simple regular expression to identify the tests missing the call to setCaptionDisplay mode, 

git grep 'kind="captions" .* default>'

so I missed several other occurrences of this issue. I now added

git grep -l -e "default.*captions.*>"

and

git grep -l -e "captions.*default.*>"

Besides, in media/track/track-cue-rendering-on-resize.html, I added setCaptionDisplayMode before the method is defined by video-test.js, so it wouldn't work.

The new patch coming hopefully addresses all this issues.
Comment 1 Simon Pena 2013-08-29 09:13:05 PDT 
Created attachment 209989 [details]
Patch
Comment 2 WebKit Commit Bot 2013-08-29 09:40:25 PDT 
Comment on attachment 209989 [details]
Patch

Clearing flags on attachment: 209989

Committed r154815: <http://trac.webkit.org/changeset/154815>
Comment 3 WebKit Commit Bot 2013-08-29 09:40:26 PDT 
All reviewed patches have been landed.  Closing bug.