Bug 120470 – Update track-remove-by-setting-innerHTML.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

The LayoutTests/media/track-remove-by-setting-innerHTML.html ensures that WebKit doesn't crash when a <video> with a <track> is removed immediately after it loads. 

The crash was caused by not cleaning up the <track> element, so the test should be updated to fail if the <track> doesn't load at all.

[Ahmad Saleem]

This test moved to WPT:

https://wpt.fyi/results/html/semantics/embedded-content/media-elements/track/track-element/track-remove-by-setting-innerHTML.html?label=experimental&label=master&aligned=

and we can delete local copy and unskip above WPT since it is passing on macOS at least.

@Eric - should I take it up from you?

___

PR idea:

1) Delete local test
2) Sync WPT test (only this particular) from WPT
3) Unskip above from 'TestExpectation' file
4) Run through EWS and see if all platform pass then good otherwise raise new bug and do platform-specific tracking

___

Appreciate your input.

[Eric Carlson]

(In reply to Ahmad Saleem from comment #1)
> This test moved to WPT:
> 
> https://wpt.fyi/results/html/semantics/embedded-content/media-elements/track/
> track-element/track-remove-by-setting-innerHTML.
> html?label=experimental&label=master&aligned=
> 
> and we can delete local copy and unskip above WPT since it is passing on
> macOS at least.
> 
> @Eric - should I take it up from you?
> 
> ___
> 
> PR idea:
> 
> 1) Delete local test
> 2) Sync WPT test (only this particular) from WPT
> 3) Unskip above from 'TestExpectation' file
> 4) Run through EWS and see if all platform pass then good otherwise raise
> new bug and do platform-specific tracking
> 
> ___
> 
> Appreciate your input.

Good idea, thanks for picking this up.

[EWS]

Committed 270001@main (402cf346e354): <https://commits.webkit.org/270001@main>

Reviewed commits have been landed. Closing PR #19680 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/117729620>