Bug 120462 - Performance tester bots should report the number of failing tests
Summary: Performance tester bots should report the number of failing tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 77037
  Show dependency tree / graph
 
Reported: 2013-08-29 04:36 PDT by Gábor Ábrahám
Modified: 2013-09-11 11:29 PDT (History)
6 users (show)

See Also:

Attachments
Proposed patch (1.43 KB, patch)
2013-09-11 05:18 PDT, Gábor Ábrahám 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gábor Ábrahám 2013-08-29 04:36:20 PDT 
It would be easier to track Perf test results with this change.
Comment 1 Gábor Ábrahám 2013-09-11 05:18:35 PDT 
Created attachment 211299 [details]
Proposed patch

Proposed fix.
Comment 2 Csaba Osztrogonác 2013-09-11 06:41:40 PDT 
Comment on attachment 211299 [details]
Proposed patch

LGTM, r=me.
Comment 3 Csaba Osztrogonác 2013-09-11 06:42:13 PDT 
Lucas, could you restart the build.webkit.org after it landed please?
Comment 4 WebKit Commit Bot 2013-09-11 07:06:29 PDT 
Comment on attachment 211299 [details]
Proposed patch

Clearing flags on attachment: 211299

Committed r155523: <http://trac.webkit.org/changeset/155523>
Comment 5 WebKit Commit Bot 2013-09-11 07:06:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Lucas Forschler 2013-09-11 08:02:37 PDT 
This patch breaks the buildbot, the indentation appears incorrect on line 674.  I've udpated the master to r155522, and restarted it.  

Please land a fix and i'll restart again.
Comment 7 Csaba Osztrogonác 2013-09-11 10:31:53 PDT 
(In reply to comment #6)
> This patch breaks the buildbot, the indentation appears incorrect on line 674.  I've udpated the master to r155522, and restarted it.  
> 
> Please land a fix and i'll restart again.

Ouch ... Sorry for the breakage. I landed the fix in
http://trac.webkit.org/changeset/155538

The problem was that rniwa used 3 spaces for indentation
in http://trac.webkit.org/changeset/105848

Additionaly there was a typo in the patch.

@Gábor, please run mastercfg_unittest.py next time yout touch the master.cfg
(I thought, you did it ... )
Comment 8 Lucas Forschler 2013-09-11 11:29:38 PDT 
master restarted.  Please watch out for any funky-ness.