Bug 120461 - Move element renderer creation out of NodeRenderingContext
Summary: Move element renderer creation out of NodeRenderingContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-29 04:04 PDT by Antti Koivisto
Modified: 2013-08-29 05:48 PDT (History)
10 users (show)

See Also:

Attachments
patch (19.42 KB, patch)
2013-08-29 04:49 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-08-29 04:04:42 PDT 
Whittle down NodeRenderingContext.
Comment 1 Antti Koivisto 2013-08-29 04:49:53 PDT 
Created attachment 209965 [details]
patch
Comment 2 Andreas Kling 2013-08-29 04:55:44 PDT 
Comment on attachment 209965 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209965&action=review

r=me, nice!

> Source/WebCore/style/StyleResolveTree.cpp:137
> +    if (!element.document()->shouldCreateRenderers())
> +        return false;

We should hoist this check up to the Document level so we don't have to run it for every Element.
Comment 3 Antti Koivisto 2013-08-29 05:48:31 PDT 
https://trac.webkit.org/r154806