Bug 120443 - [WebGL] CoreGraphics can provide greyscale image data
Summary: [WebGL] CoreGraphics can provide greyscale image data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-28 16:39 PDT by Dean Jackson
Modified: 2013-08-28 16:53 PDT (History)
2 users (show)

See Also:


Attachments
Patch (44.12 KB, patch)
2013-08-28 16:45 PDT, Dean Jackson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-08-28 16:39:05 PDT
GraphicsContext3D::srcFormatComeFromDOMElementOrImageData checks for some defined image formats to decide whether or not the data came from an <img> element. However, it is too restrictive for CoreGraphics, causing us to fail unpacking some image data.

<rdar://problem/14840310>
Comment 1 Dean Jackson 2013-08-28 16:45:18 PDT
Created attachment 209932 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-08-28 16:48:48 PDT
Comment on attachment 209932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209932&action=review

> LayoutTests/fast/canvas/webgl/tex-image-with-greyscale-image.html:4
> +<meta charset="utf-8">

Nuke this.
Comment 3 Dean Jackson 2013-08-28 16:53:33 PDT
Committed r154793: <http://trac.webkit.org/changeset/154793>