120441 – Remove unneeded setNeedsLayouts from RenderTableSection

Bug 120441 - Remove unneeded setNeedsLayouts from RenderTableSection

Summary: Remove unneeded setNeedsLayouts from RenderTableSection

Status:	RESOLVED CONFIGURATION CHANGED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Layout and Rendering (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:	BlinkMergeCandidate

Depends on:
Blocks:

Reported:	2013-08-28 16:20 PDT by Ryosuke Niwa
Modified:	2022-09-14 21:25 PDT (History)
CC List:	6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ryosuke Niwa 2013-08-28 16:20:46 PDT

Consider merging https://chromium.googlesource.com/chromium/blink/+/8e2f19c539881025022d3ff799066a06a95bc490

As best I can tell, these setNeedsLayouts don't accomplish anything.
Elliott and I dug through the changes that added them. The tests
added with those patches pass without the setNeedsLayouts. We tried
for a while to come up with a test case the setNeedsLayouts were
needed and couldn't.

The cellChildrenFlex part is needed though so that we only call
setOverrideLogicalContentHeightFromRowHeight in the right cases.

Comment 1 Ahmad Saleem 2022-09-13 16:40:34 PDT

This is added now:

-> shouldFlexCellChild

https://github.com/WebKit/WebKit/blob/27705761a29a1f7a1625264d72425f9dffe49f58/Source/WebCore/rendering/RenderTableSection.cpp#L470

and other bits

https://github.com/WebKit/WebKit/blob/27705761a29a1f7a1625264d72425f9dffe49f58/Source/WebCore/rendering/RenderTableSection.cpp#L497

___

I don't think this is needed anymore. Thanks!