Bug 120441 – Remove unneeded setNeedsLayouts from RenderTableSection

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: Layout and Rendering

[Ryosuke Niwa]

Consider merging https://chromium.googlesource.com/chromium/blink/+/8e2f19c539881025022d3ff799066a06a95bc490

As best I can tell, these setNeedsLayouts don't accomplish anything.
Elliott and I dug through the changes that added them. The tests
added with those patches pass without the setNeedsLayouts. We tried
for a while to come up with a test case the setNeedsLayouts were
needed and couldn't.

The cellChildrenFlex part is needed though so that we only call
setOverrideLogicalContentHeightFromRowHeight in the right cases.

[Ahmad Saleem]

This is added now:

-> shouldFlexCellChild

https://github.com/WebKit/WebKit/blob/27705761a29a1f7a1625264d72425f9dffe49f58/Source/WebCore/rendering/RenderTableSection.cpp#L470

and other bits

https://github.com/WebKit/WebKit/blob/27705761a29a1f7a1625264d72425f9dffe49f58/Source/WebCore/rendering/RenderTableSection.cpp#L497

___

I don't think this is needed anymore. Thanks!