Bug 120436 - Fix compositing layers in columns
Summary: Fix compositing layers in columns
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-28 13:54 PDT by Simon Fraser (smfr)
Modified: 2013-08-28 15:52 PDT (History)
5 users (show)

See Also:

Attachments
Patch (39.29 KB, patch)
2013-08-28 13:58 PDT, Simon Fraser (smfr) 		hyatt: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-08-28 13:54:14 PDT 
Fix compositing layers in columns
Comment 1 Simon Fraser (smfr) 2013-08-28 13:58:28 PDT 
Created attachment 209920 [details]
Patch
Comment 2 Dave Hyatt 2013-08-28 14:00:03 PDT 
Comment on attachment 209920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209920&action=review

r=me

> Source/WebCore/rendering/RenderLayer.h:605
> +    enum ColumnOffsetAdjustment { DontAdjustForColumns, AdjustForColumns };
> +    void convertToPixelSnappedLayerCoords(const RenderLayer* ancestorLayer, IntPoint& location, ColumnOffsetAdjustment adjustForColumns = DontAdjustForColumns) const;
> +    void convertToPixelSnappedLayerCoords(const RenderLayer* ancestorLayer, IntRect&, ColumnOffsetAdjustment adjustForColumns = DontAdjustForColumns) const;
> +    void convertToLayerCoords(const RenderLayer* ancestorLayer, LayoutPoint&, ColumnOffsetAdjustment adjustForColumns = DontAdjustForColumns) const;
> +    void convertToLayerCoords(const RenderLayer* ancestorLayer, LayoutRect&, ColumnOffsetAdjustment adjustForColumns = DontAdjustForColumns) const;

I think above these functions would be a good place for a FIXME describing that this is just a hack to get compositing layers to show up in a single column, and that eventually we want them to work when split across columns.
Comment 3 Simon Fraser (smfr) 2013-08-28 15:52:24 PDT 
https://trac.webkit.org/r154785

<rdar://problem/14664586>