Bug 120435 - Decrease number of workers used in NRWT by the Windows port
Summary: Decrease number of workers used in NRWT by the Windows port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Roger Fong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-28 12:26 PDT by Roger Fong
Modified: 2013-08-28 13:33 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.14 KB, patch)
2013-08-28 13:19 PDT, Roger Fong 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-08-28 12:26:00 PDT 
Right now we're maxing out the number of workers.
This tends to cause various issues such as test results being off by 1, flakiness, and occasional timeouts.
Maxing out the number of threads might actually in some cases slow down the test cases rather than speed them up.
Decreasing the number of workers to half the available cores (just to be on the safe side).
Comment 1 Roger Fong 2013-08-28 13:19:57 PDT 
Created attachment 209918 [details]
Patch
Comment 2 Brent Fulgham 2013-08-28 13:28:38 PDT 
Comment on attachment 209918 [details]
Patch

Yes! r=me.
Comment 3 Roger Fong 2013-08-28 13:33:43 PDT 
Awesome thanks, hopefully we'll start seeing some more stability in the bots now.
Committed: https://trac.webkit.org/r154776