The current handlers for things like "Content with specified MIME type can't be shown" and "Not allowed to use restricted network port" simply return an empty string for display to the user. This results in mysterious blank "OK" alert boxes that are the only clue that something went wrong with Windows WebKit when attempting to view some content. This bug uses the existing WEB_UI_STRINGS defined for these error codes and allows Windows WebKit to display them.
<rdar://problem/14858310>
Created attachment 209906 [details] Patch
Attachment 209906 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp']" exit_code: 1 Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:883: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:893: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1147: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1151: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3) > Attachment 209906 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp']" exit_code: 1 > Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:883: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] > Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:893: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] > Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1147: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] > Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1151: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] > Total errors found: 4 in 2 files The character codes must be present to match the existing string keys in the localizedStrings file.
Committed r154764: <http://trac.webkit.org/changeset/154764>