Bug 120415 - [curl] Remove unused includes.
Summary: [curl] Remove unused includes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-28 07:13 PDT by Tamas Czene
Modified: 2013-11-11 09:35 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (2.04 KB, patch)
2013-08-28 07:14 PDT, Tamas Czene
no flags Details | Formatted Diff | Diff
updated patch (2.18 KB, patch)
2013-11-06 01:24 PST, Gergő Balogh
ossy: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
updated patch (1.48 KB, patch)
2013-11-11 06:30 PST, Gergő Balogh
andersca: review+
andersca: commit-queue+
Details | Formatted Diff | Diff
updated patch (2.11 KB, patch)
2013-11-11 07:14 PST, Gergő Balogh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Czene 2013-08-28 07:13:43 PDT
[curl] Remove unused includes.
Comment 1 Tamas Czene 2013-08-28 07:14:57 PDT
Created attachment 209883 [details]
proposed patch
Comment 2 Brent Fulgham 2013-10-30 10:22:13 PDT
Comment on attachment 209883 [details]
proposed patch

r=me.
Comment 3 WebKit Commit Bot 2013-10-30 10:28:19 PDT
Comment on attachment 209883 [details]
proposed patch

Rejecting attachment 209883 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 209883, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
WebCore/platform/network/curl/ProxyServerCurl.cpp.rej
patching file Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp
patching file Source/WebCore/platform/network/curl/ResourceHandleManager.cpp
Hunk #1 FAILED at 39.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/network/curl/ResourceHandleManager.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/17038242
Comment 4 Peter Gal 2013-10-30 10:30:29 PDT
It seems it seems the patch is a bit outdated :)
Comment 5 Gergő Balogh 2013-11-06 01:24:45 PST
Created attachment 216153 [details]
updated patch
Comment 6 Csaba Osztrogonác 2013-11-07 03:44:31 PST
Comment on attachment 216153 [details]
updated patch

r=me
Comment 7 WebKit Commit Bot 2013-11-07 03:47:24 PST
Comment on attachment 216153 [details]
updated patch

Rejecting attachment 216153 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 216153, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/22778149
Comment 8 Csaba Osztrogonác 2013-11-07 04:39:13 PST
Comment on attachment 216153 [details]
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216153&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests (OOPS!).

Please remove this line
Comment 9 Gergő Balogh 2013-11-11 06:30:11 PST
Created attachment 216563 [details]
updated patch
Comment 10 WebKit Commit Bot 2013-11-11 06:31:49 PST
Attachment 216563 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Gergő Balogh 2013-11-11 07:14:22 PST
Created attachment 216570 [details]
updated patch
Comment 12 WebKit Commit Bot 2013-11-11 09:35:25 PST
Comment on attachment 216570 [details]
updated patch

Clearing flags on attachment: 216570

Committed r159053: <http://trac.webkit.org/changeset/159053>
Comment 13 WebKit Commit Bot 2013-11-11 09:35:27 PST
All reviewed patches have been landed.  Closing bug.