Bug 120413 - [curl] Use utf8 for headers in CurlDownload.
Summary: [curl] Use utf8 for headers in CurlDownload.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Curl
Depends on:
Blocks: 117300
  Show dependency tree / graph
 
Reported: 2013-08-28 07:07 PDT by Tamas Czene
Modified: 2013-09-12 11:28 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch (1.28 KB, patch)
2013-08-28 07:10 PDT, Tamas Czene 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Czene 2013-08-28 07:07:22 PDT 
[curl] Use utf8 for headers in CurlDownload.
Comment 1 Tamas Czene 2013-08-28 07:10:24 PDT 
Created attachment 209881 [details]
proposed patch
Comment 2 Anders Carlsson 2013-09-02 07:23:18 PDT 
(In reply to comment #0)
> [curl] Use utf8 for headers in CurlDownload.

Why?
Comment 3 Peter Gal 2013-09-04 10:31:34 PDT 
(In reply to comment #2)
> (In reply to comment #0)
> > [curl] Use utf8 for headers in CurlDownload.
> 
> Why?

I think because the header can contain utf8 characters, like for example the name of the file can be in utf8 (in the content-disposition header). There is also a testcase for this: http/tests/download/literal-utf-8.html.
Comment 4 Brent Fulgham 2013-09-12 11:04:58 PDT 
Comment on attachment 209881 [details]
proposed patch

Seems find, and unlikely to hurt any other port.  r=me.
Comment 5 WebKit Commit Bot 2013-09-12 11:28:27 PDT 
Comment on attachment 209881 [details]
proposed patch

Clearing flags on attachment: 209881

Committed r155634: <http://trac.webkit.org/changeset/155634>
Comment 6 WebKit Commit Bot 2013-09-12 11:28:29 PDT 
All reviewed patches have been landed.  Closing bug.