Bug 120406 - [GTK] [WK2] TestWebKitWebView page-visibility fails
Summary: [GTK] [WK2] TestWebKitWebView page-visibility fails
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Holt
Depends on:
Blocks: 117689
  Show dependency treegraph
Reported: 2013-08-28 06:17 PDT by Brian Holt
Modified: 2013-08-29 10:21 PDT (History)
5 users (show)

See Also:

Patch (4.50 KB, patch)
2013-08-28 09:16 PDT, Brian Holt
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Holt 2013-08-28 06:17:43 PDT
The unit test for page-visibility fails because the return value from JS is not a string.

ERROR:../../Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp:366:char* jsValueToCString(JSGlobalContextRef, JSValueRef): assertion failed: (JSValueIsString(context, value))
Comment 1 Brian Holt 2013-08-28 09:16:39 PDT
Created attachment 209895 [details]
Comment 2 WebKit Commit Bot 2013-08-28 09:17:53 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Brian Holt 2013-08-28 09:19:18 PDT
It looks like this test was missed when the prefixes were removed in https://bugs.webkit.org/show_bug.cgi?id=102340.

The proposed patch fixes this specific issue, but there are still others preventing TestWebKitWebView from running.
Comment 4 Gustavo Noronha (kov) 2013-08-29 10:07:10 PDT
Comment on attachment 209895 [details]

Comment 5 WebKit Commit Bot 2013-08-29 10:21:14 PDT
Comment on attachment 209895 [details]

Clearing flags on attachment: 209895

Committed r154818: <http://trac.webkit.org/changeset/154818>
Comment 6 WebKit Commit Bot 2013-08-29 10:21:16 PDT
All reviewed patches have been landed.  Closing bug.