Bug 120378 - Code cleanup: rename FloatIntervalSearchAdapter and remove unnecessary inlines
Summary: Code cleanup: rename FloatIntervalSearchAdapter and remove unnecessary inlines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-08-27 15:24 PDT by Bem Jones-Bey
Modified: 2013-08-28 16:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.96 KB, patch)
2013-08-27 15:30 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Patch (9.72 KB, patch)
2013-08-28 09:44 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-08-27 15:24:09 PDT 
Code cleanup: rename FloatIntervalSearchAdapter tand remove unnecessary inlines
Comment 1 Bem Jones-Bey 2013-08-27 15:30:53 PDT 
Created attachment 209810 [details]
Patch

Port patches from Blink
Comment 2 Darin Adler 2013-08-27 18:12:51 PDT 
Comment on attachment 209810 [details]
Patch

Changes are OK. But I don’t really want to read about Blink. I’d like to read about the merits of the change, not a blow-by-blow of the Blink development process.
Comment 3 Bem Jones-Bey 2013-08-28 08:38:51 PDT 
(In reply to comment #2)
> (From update of attachment 209810 [details])
> Changes are OK. But I don’t really want to read about Blink. I’d like to read about the merits of the change, not a blow-by-blow of the Blink development process.

Can you cite any specific changes that I could make to the way that I write changelogs for ports from Blink that would make you feel more comfortable with it? I'm not particularly attached to any specific format, so if there's a way I could write it that you prefer, I would be happy to do that.
Comment 4 Bem Jones-Bey 2013-08-28 09:44:20 PDT 
Created attachment 209899 [details]
Patch

Review feedback
Comment 5 WebKit Commit Bot 2013-08-28 10:10:59 PDT 
Comment on attachment 209899 [details]
Patch

Clearing flags on attachment: 209899

Committed r154758: <http://trac.webkit.org/changeset/154758>
Comment 6 WebKit Commit Bot 2013-08-28 10:11:01 PDT 
All reviewed patches have been landed.  Closing bug.