RESOLVED FIXED 120378
Code cleanup: rename FloatIntervalSearchAdapter and remove unnecessary inlines 
https://bugs.webkit.org/show_bug.cgi?id=120378
Summary Code cleanup: rename FloatIntervalSearchAdapter and remove unnecessary inlines
Bem Jones-Bey
Reported 2013-08-27 15:24:09 PDT
Code cleanup: rename FloatIntervalSearchAdapter tand remove unnecessary inlines
Attachments
Patch (9.96 KB, patch)
2013-08-27 15:30 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Patch (9.72 KB, patch)
2013-08-28 09:44 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2013-08-27 15:30:53 PDT
Created attachment 209810 [details] Patch Port patches from Blink
Darin Adler
Comment 2 2013-08-27 18:12:51 PDT
Comment on attachment 209810 [details] Patch Changes are OK. But I don’t really want to read about Blink. I’d like to read about the merits of the change, not a blow-by-blow of the Blink development process.
Bem Jones-Bey
Comment 3 2013-08-28 08:38:51 PDT
(In reply to comment #2) > (From update of attachment 209810 [details]) > Changes are OK. But I don’t really want to read about Blink. I’d like to read about the merits of the change, not a blow-by-blow of the Blink development process. Can you cite any specific changes that I could make to the way that I write changelogs for ports from Blink that would make you feel more comfortable with it? I'm not particularly attached to any specific format, so if there's a way I could write it that you prefer, I would be happy to do that.
Bem Jones-Bey
Comment 4 2013-08-28 09:44:20 PDT
Created attachment 209899 [details] Patch Review feedback
WebKit Commit Bot
Comment 5 2013-08-28 10:10:59 PDT
Comment on attachment 209899 [details] Patch Clearing flags on attachment: 209899 Committed r154758: <http://trac.webkit.org/changeset/154758>
WebKit Commit Bot
Comment 6 2013-08-28 10:11:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.